shamhub: Compute review thread staleness - #1222
Merged
Merged
Conversation
This was referenced Jun 2, 2026
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 2, 2026 20:08
13fcb5b to
ce6c1aa
Compare
Collaborator
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Jun 2, 2026
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 2, 2026 20:22
d42cd46 to
e683e4f
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 2, 2026 22:20
5582ec7 to
ee1f597
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
2 times, most recently
from
June 8, 2026 10:18
bc2d528 to
5228b63
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 8, 2026 10:18
ee1f597 to
9f8657d
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 8, 2026 11:15
d270ec2 to
0a8ca42
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 8, 2026 11:15
1113e5d to
312db25
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 12, 2026 20:07
0a8ca42 to
03fafd4
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 12, 2026 20:07
312db25 to
6ab1da8
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 13, 2026 13:39
03fafd4 to
1f477e3
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 13, 2026 13:39
6ab1da8 to
167cca4
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 15, 2026 09:52
1f477e3 to
7241e23
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 15, 2026 09:52
167cca4 to
d049480
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 19, 2026 01:03
f84f05d to
c2cb662
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 19, 2026 01:04
41864dd to
93682d9
Compare
ed-irl
force-pushed
the
branch-comment-tests
branch
from
June 24, 2026 01:32
c2cb662 to
63cfc0c
Compare
ed-irl
force-pushed
the
branch-comment-stale
branch
from
June 24, 2026 01:32
93682d9 to
e8e87b4
Compare
abhinav
changed the base branch from
branch-comment-tests
to
branch-comment-forge
August 24, 2026 05:14
abhinav
force-pushed
the
branch-comment-stale
branch
from
August 24, 2026 05:14
e8e87b4 to
4b111e1
Compare
abhinav
force-pushed
the
branch-comment-forge
branch
2 times, most recently
from
August 24, 2026 05:18
9319b93 to
d2f5157
Compare
abhinav
force-pushed
the
branch-comment-stale
branch
2 times, most recently
from
August 24, 2026 12:45
8a84101 to
7f6c184
Compare
ShamHub records the reviewed head in ReviewThread.CommitHash. When that revision differs from the current change head, compare the two revisions and mark a right-side thread outdated if the later patch deletes any line in its inclusive range. Insertions do not stale an anchor. File-level and left-side threads retain their stored state because the recorded commit does not identify a comparable old-side range for those anchors. Explicitly seeded outdated state still takes precedence, and diff failures propagate to the caller.
abhinav
force-pushed
the
branch-comment-stale
branch
from
August 30, 2026 17:42
7f6c184 to
9962fb8
Compare
abhinav
marked this pull request as ready for review
August 30, 2026 17:42
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShamHub review threads record the change head in
ReviewThread.CommitHash. When that revision differs from the current head, compare the two revisions and mark a right-side thread outdated only when the later patch deletes a line in its inclusive range.Insertions alone do not stale an anchor. File-level and left-side threads retain their stored state because their recorded coordinates do not identify a comparable source range. Explicitly seeded outdated state still takes precedence, and diff or parsing failures propagate to the caller.
This builds on the review patch queries from #1162. The user-facing staleness script is included with the commands in #1163.