review: Separate commands from workflows - #1432
Merged
Merged
Conversation
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Sep 1, 2026
Review commands currently own parsing, state access, forge access, and presentation. That coupling hides workflow behavior inside command shims and exposes persistence details at the command boundary. Introduce review-domain values and handlers for local draft and remote review workflows. Commands now parse syntax and present results. Dependency wiring requires each forge capability that a remote workflow uses.
Review handlers accepted empty branch names and hid single-branch lookups behind shallow helpers. Review-domain values also required constructors and accessors without protecting additional invariants. Resolve omitted branches in the command adapters. Expose review anchors and drafts as documented values, and keep forge, change, and thread resolution in the workflows that use them. Kong now rejects conflicting review dispositions and presents the accepted anchor syntax directly.
abhinav
force-pushed
the
review-command-cleanup
branch
from
September 6, 2026 01:50
412b937 to
2dfd300
Compare
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review commands currently own parsing, state access, forge access, and
presentation.
That coupling hides workflow behavior inside command shims and exposes
persistence details at the command boundary.
Introduce review-domain values and handlers
for local draft and remote review workflows.
Commands now parse syntax and present results.
Dependency wiring requires each forge capability
that a remote workflow uses.