state: Make review draft updates atomic - #1438
Merged
Merged
Conversation
Concurrent review commands can derive changes from one draft document. Saving either precomputed document can discard the winning change or assign one branch-local ID twice. Store drafts in an ID-keyed object and update additions and edits with replayable JSON transformations. Concurrent additions receive distinct IDs, while edits to separate drafts preserve both changes.
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent review commands can derive changes from one draft document.
Saving either precomputed document can discard the winning change
or assign one branch-local ID twice.
Store drafts in an ID-keyed object
and update additions and edits with replayable JSON transformations.
Concurrent additions receive distinct IDs,
while edits to separate drafts preserve both changes.