review: Remap drafts to remote change head - #1445
Draft
abhinav wants to merge 1 commit into
Draft
Conversation
Review comment drafts need a stable revision for their file and line anchors. Record the local branch head before opening the comment editor so concurrent branch movement cannot pair an old anchor with a newer commit. At publication, retrieve the forge's current change head and map each root anchor from its recorded commit to that remote revision. Use the same remote head for review-patch validation so submitted coordinates and local checks describe one revision. Reuse one lazily loaded source-to-head patch for drafts that share a source commit. Mapping follows ordinary edits and Git-detected renames for file, line, and range comments. A source or diff-loading failure warns and falls back to the saved coordinate; a target deleted without replacement remains an error. No refs are retained solely for draft comments.
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comment drafts need a stable revision for their file and line anchors.
Record the local branch head before opening the comment editor so concurrent
branch movement cannot pair an old anchor with a newer commit.
At publication, retrieve the forge's current change head and map each root
anchor from its recorded commit to that remote revision.
Use the same remote head for review-patch validation so submitted coordinates
and local checks describe one revision.
Reuse one lazily loaded source-to-head patch for drafts that share a source
commit.
Mapping follows ordinary edits and Git-detected renames for file, line, and
range comments.
A source or diff-loading failure warns and falls back to the saved coordinate;
a target deleted without replacement remains an error.
No refs are retained solely for draft comments.