review: Accept file and range drafts - #1443
Merged
Merged
Conversation
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Sep 6, 2026
Review comment anchors accept a file, a postimage line, or an inclusive postimage line range. Immediate comments already preserve all three scopes, but local drafts retain only one line. Persist and display each draft's complete anchor. Keep the existing `line` field compatible with single-line records, and submit the original scope when the draft is published.
abhinav
force-pushed
the
review-draft-scopes
branch
from
September 6, 2026 12:41
64ff4d1 to
7b84196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comment anchors accept a file,
a postimage line,
or an inclusive postimage line range.
Immediate comments already preserve all three scopes,
but local drafts retain only one line.
Persist and display each draft's complete anchor.
Keep the existing
linefield compatible with single-line records,and submit the original scope when the draft is published.