state: Preserve drafts changed during publication - #1440
Merged
Conversation
A forge request runs without holding a state snapshot. A concurrent command can add, edit, or remove drafts before the request returns. Remove only drafts whose stored values match the submitted review. Express cleanup as replayable JSON member deletions, so storage retries preserve concurrent additions and edits. If the branch is untracked during submission, do not recreate its draft state.
Published drafts leave the branch allocator intact. A later cleanup could otherwise reset the allocator and reuse an identifier that a user still remembers. Cover publication followed by another draft through state and command boundaries. The next draft must receive a larger branch-local ID.
Owner
Author
|
This change is part of the following stack:
Change managed by git-spice. |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A forge request runs without holding a state snapshot.
A concurrent command can add, edit, or remove drafts
before the request returns.
Remove only drafts whose stored values match the submitted review.
Express cleanup as replayable JSON member deletions,
so storage retries preserve concurrent additions and edits.
If the branch is untracked during submission,
do not recreate its draft state.