Rename SimDataformats TICL associator as `TICLAssociationMap` by sbaldu · Pull Request #51649 · cms-sw/cmssw

sbaldu · 2026-08-07T13:50:15Z

PR description:

PR #49995 introduces a new heterogeneous Association Map under the ticl namespace. This PR renames the ticl::AssociationMap defined under SimDataFormats/Associations to avoid clashes inside TICL code.

FYI @waredjeb

cmsbuild · 2026-08-07T13:50:47Z

cms-bot internal usage

cmsbuild · 2026-08-07T13:52:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51649/50505

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllHitToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllLayerClusterToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByLCsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToTracksterAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToTSAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): Particle Flow cluster validation in ECAL #50292, Updates to L1 tracking code from entire L1 track community #51503, [NGT] Introduce general DQM Validation for Secondary Vertexing #51577
- File Validation/HGCalValidation/interface/BarrelVHistoProducerAlgo.h modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File Validation/HGCalValidation/interface/BarrelValidator.h modified in PR(s): Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047
- File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319, Update TICL & HGCal simulation truth validation to use new simulation truth collections, and simplify validation to use only SimCluster dataformat #51047, HGCal validation histograms refactor #51565
- File Validation/HGCalValidation/interface/TICLCandidateValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2026-08-07T13:53:05Z

A new Pull Request was created by @sbaldu for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/TruthInfo (generators)
RecoHGCal/TICL (reconstruction)
SimCalorimetry/HGCalAssociatorProducers (simulation)
SimDataFormats/Associations (simulation)
Validation/HGCalValidation (dqm)

@Moanwar, @battibass, @civanch, @cmsbuild, @ctarricone, @ftorrresd, @gabrielmscampos, @jfernan2, @kpedro88, @lviliani, @mandrenguyen, @mdhildreth, @mkirsano, @rseidita, @sensrcn, @srimanob, @theofil can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @fabiocos, @felicepantaleo, @gpetruc, @hatakeyamak, @lecriste, @lgray, @martinamalberti, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @sobhatta, @vandreev11 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

gabrielmscampos · 2026-08-07T15:19:43Z

please test

cmsbuild · 2026-08-07T17:29:09Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0a44d/55174/summary.html
COMMIT: b2d5c50
CMSSW: CMSSW_20_1_X_2026-08-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51649/55174/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test testMakeHGCalValidationPlots had ERRORS

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3589140
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3589117
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

waredjeb · 2026-08-10T08:24:32Z

From the log https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b0a44d/55174/unitTests/log.txt

Preparing to run 29690.0 SingleGammaPt25Eta1p7_2p7+Run4D110

# in: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_20_1_X_2026-08-07-1100/unit_tests/testMakeHGCalValidationPlots going to execute cd 29690.0_SingleGammaPt25Eta1p7_2p7+Run4D110
 cmsDriver.py step4  -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --conditions auto:phase2_realistic_T35 --mc  --geometry ExtendedRun4D110 --scenario pp --filetype DQM --era Phase2C17I13M9 -s HARVESTING:@HGCalValidation -n 100  --filein das:/RelValTTbar_14TeV/CMSSW_15_1_0-150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/DQMIO --fileout file:step4.root  > step4_SingleGammaPt25Eta1p7_2p7+Run4D110.log  2>&1
 
ERROR executing  cd 29690.0_SingleGammaPt25Eta1p7_2p7+Run4D110; cmsDriver.py step4  -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --conditions auto:phase2_realistic_T35 --mc  --geometry ExtendedRun4D110 --scenario pp --filetype DQM --era Phase2C17I13M9 -s HARVESTING:@HGCalValidation -n 100  --filein das:/RelValTTbar_14TeV/CMSSW_15_1_0-150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/DQMIO --fileout file:step4.root  > step4_SingleGammaPt25Eta1p7_2p7+Run4D110.log  2>&1;  ret= 21504
29690.0_SingleGammaPt25Eta1p7_2p7+Run4D110 Step0-FAILED Step1-NOTRUN  - time date Fri Aug  7 18:05:24 2026-date Fri Aug  7 17:47:00 2026; exit: 21504 0
0 0 tests passed, 1 0 failed

HARVESTING:@HGCalValidation
entry das:/RelValTTbar_14TeV/CMSSW_15_1_0-150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/DQMIO
the query is file dataset = /RelValTTbar_14TeV/CMSSW_15_1_0-150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/DQMIO
DAS succeeded after 1 attempts 0
found files:  ['/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root']
Step: HARVESTING Spec: ['@HGCalValidation']
Starting  cmsRun  step4_HARVESTING.py
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 17:47:11 CEST  BeforeEvents
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=caf6ff61-e45a-44a5-92aa-e31001758f9f.
%MSG
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 17:47:11 CEST  BeforeEvents
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=c9c3de3b-7c5f-404b-8731-60228cda57cf.
%MSG
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 17:47:43 CEST  BeforeEvents
Failed to open file at URL root://cms-xrd-global.cern.ch:1094//eos/cms/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=5369af4d-344d-45f9-8f4c-5bef59c65bc8.
%MSG
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 17:47:43 CEST  BeforeEvents
Failed to open file at URL root://cms-xrd-global.cern.ch:1094//eos/cms/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=f45fbf97-1504-4254-9c8d-af64709aee64.
%MSG
[2026-08-07 17:56:34.603108 +0200][Error  ][XRootD            ] [xrootd-cms.infn.it:1094] Unable to get the response to request kXR_open (file: /store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206, mode: 0460, flags: kXR_open_read kXR_4dirlist kXR_async kXR_retstat flagt: none fhtemplt: 0x00000000)
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 17:56:34 CEST  BeforeEvents
Failed to open file at URL root://xrootd-cms.infn.it:1094//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=89bc166c-fe20-43c0-9a96-19b5a041e7ac.
%MSG
[2026-08-07 18:05:24.670503 +0200][Error  ][XRootD            ] [xrootd-cms.infn.it:1094] Unable to get the response to request kXR_open (file: /store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206, mode: 0460, flags: kXR_open_read kXR_4dirlist kXR_async kXR_retstat flagt: none fhtemplt: 0x00000000)
%MSG-w XrdAdaptorInternal:  AfterModBeginStream 07-Aug-2026 18:05:24 CEST  BeforeEvents
Failed to open file at URL root://xrootd-cms.infn.it:1094//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=0bcde952-53ff-4f80-9db1-3bea4555e4ff.
%MSG
----- Begin Fatal Exception 07-Aug-2026 18:05:24 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Calling InputSource::readFile_
   [1] Opening DQM Root file
   [2] Calling StorageFactory::open()
   [3] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206'
Input file root://xrootd-cms.infn.it//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206 was not found, could not be opened, or is corrupted.
   Additional Info:
      [a] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [b] Last URL tried: root://cms-xrd-global.cern.ch:1094//eos/cms/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=f45fbf97-1504-4254-9c8d-af64709aee64
      [c] Problematic data server: cms-xrd-global.cern.ch:1094
      [d] Disabled source: cms-xrd-global.cern.ch:1094
      [e] XrdCl::File::Open(name='root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] Unable to open file /eos/cms/store/user/cmsbuild/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root; No such file or directory
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=c9c3de3b-7c5f-404b-8731-60228cda57cf
      [g] Problematic data server: eoscms.cern.ch:1094
      [h] Disabled source: eoscms.cern.ch:1094
      [i] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206', flags=0x10, permissions=0660) => error '[ERROR] Operation expired' (errno=0, code=206). No additional data servers were found.
      [j] Last URL tried: root://xrootd-cms.infn.it:1094//store/relval/CMSSW_15_1_0/RelValTTbar_14TeV/DQMIO/150X_mcRun4_realistic_v1_STD_RecycledGS_Run4D110_noPU-v2/2580000/A15356AB-757E-4C84-B709-24BEA9C71471.root?scitag.flow=206&xrdcl.requuid=0bcde952-53ff-4f80-9db1-3bea4555e4ff
      [k] Problematic data server: xrootd-cms.infn.it:1094
      [l] Disabled source: xrootd-cms.infn.it:1094
----- End Fatal Exception -------------------------------------------------
Could not run HARVESTING: status 1

---> test testMakeHGCalValidationPlots had ERRORS
TestTime:1131
^^^^ End Test testMakeHGCalValidationPlots ^^^^
Fail 1131s ... Validation/HGCalValidation/testMakeHGCalValidationPlots
>> Test sequence completed for CMSSW CMSSW_20_1_X_2026-08-07-1100
+ echo ALL_OK
ALL_OK

Seems like a problem with the input files?

gabrielmscampos · 2026-08-12T10:01:02Z

please test

let's try again

sensrcn · 2026-08-13T15:58:30Z

+generators

Moanwar · 2026-08-17T12:50:28Z

+1

ftorrresd · 2026-08-18T23:47:17Z

+xpog

civanch · 2026-08-20T18:09:55Z

+1

cmsbuild · 2026-08-20T18:10:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-08-21T09:33:26Z

+1

smuzaffar · 2026-08-23T09:06:25Z

@sbaldu , some unit tests start failing with error [a] . Looks like change in this PR is causing such issues in IBs. Can you please look in to it?

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_amd64_gcc14/CMSSW_20_1_X_2026-08-21-2300/unitTestLogs/Alignment/OfflineValidation#/

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

sbaldu · 2026-08-24T07:13:24Z

@sbaldu , some unit tests start failing with error [a] . Looks like change in this PR is causing such issues in IBs. Can you please look in to it?

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_amd64_gcc14/CMSSW_20_1_X_2026-08-21-2300/unitTestLogs/Alignment/OfflineValidation#/


  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinks_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlCandidate_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlCandidate_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinks_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlCandidate_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.



If you do not need these branches and they are not produced

in the current process, an alternate solution to adding

dictionaries is to drop these branches on input using the

inputCommands parameter of the PoolSource.

----- End Fatal Exception -------------------------------------------------

Yes I will look into that

sbaldu · 2026-08-26T09:00:23Z

@sbaldu , some unit tests start failing with error [a] . Looks like change in this PR is causing such issues in IBs. Can you please look in to it?

[a] https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_amd64_gcc14/CMSSW_20_1_X_2026-08-21-2300/unitTestLogs/Alignment/OfflineValidation#/

  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByHits_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlCandidateToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlCandidate_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinksSuperclusteringDNN_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTracksterLinks_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlSimTrackstersfromCPsToticlTrackstersCLUE3DHigh_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksSuperclusteringDNNToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTracksterLinksToticlSimTrackstersfromCPs_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTracksters_RECO.
  ticlSharedEnergyTypefloatstdpairticlAssociationElementssticlTrackstersticlTrackstersticlAssociationMap_allTrackstersToSimTrackstersAssociationsByLCs_ticlTrackstersCLUE3DHighToticlSimTrackstersfromCPs_RECO.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

FYI @Electricks94
The problem is that, since the data structure was renamed, ROOT cannot find the dictionary anymore. It is possible to provide a schema evolution to tell ROOT to look for the maps using the new name.
Is this the way we should go or is it easier to just reproduce the relvals with the new name?

mmusich · 2026-08-26T09:20:43Z

Is this the way we should go or is it easier to just reproduce the relvals with the new name?

@sbaldu FYI this is also discussed at #51756.
Waiting for the next round of relval production and let the test fail for weeks on end is not an option.
May I recommend instead to try the approach of dropping the offending input branches (presumably not consumed in the unit tests jobs) in the same fashion of this commit acda5d5 as a temporary measure?

Rename SimDataformats TICL associator as TICLAssociationMap

b2d5c50

cmsbuild added this to the CMSSW_20_1_X milestone Aug 7, 2026

cmsbuild added reconstruction-pending simulation-pending dqm-pending generators-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending changes-dataformats labels Aug 7, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 7, 2026

cmsbuild mentioned this pull request Aug 7, 2026

[NGT] Introduce general DQM Validation for Secondary Vertexing #51577

Merged

cmsbuild added tests-started and removed tests-pending labels Aug 7, 2026

cmsbuild added tests-rejected and removed tests-started labels Aug 7, 2026

cmsbuild mentioned this pull request Aug 9, 2026

Revert PR #51563 #51656

Closed

cmsbuild mentioned this pull request Aug 12, 2026

Introspection for SoABlocks #51670

Merged

cmsbuild added tests-started and removed tests-rejected labels Aug 12, 2026

cmsbuild added generators-approved and removed generators-pending labels Aug 13, 2026

cmsbuild mentioned this pull request Aug 16, 2026

Truth Graph: Introducing Levels #51716

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 17, 2026

cmsbuild added xpog-approved and removed xpog-pending labels Aug 18, 2026

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels Aug 20, 2026

cmsbuild added orp-approved and removed orp-pending labels Aug 21, 2026

cmsbuild merged commit 894c687 into cms-sw:master Aug 21, 2026
10 checks passed

This was referenced Aug 22, 2026

Tensorflow 2.21 and related changes cms-sw/cmsdist#10789

Merged

Changes needed for updatign TF to version 2.21 #51713

Merged

akritkbehera mentioned this pull request Aug 25, 2026

DictionaryNotFound: files written before #51649 are unreadable after the ticl::AssociationMap rename #51756

Closed

sbaldu deleted the refactor/rename-simdataformats-associationamp branch August 25, 2026 14:14

sbaldu mentioned this pull request Aug 27, 2026

Temporarily drop ticl::TICLAssociationMap for backward-compatibility #51765

Merged

fwyzard mentioned this pull request Aug 28, 2026

Catch renamed or removed dictionaries in PR tests #51775

Open

Uh oh!

Conversation

sbaldu commented Aug 7, 2026

PR description:

Uh oh!

cmsbuild commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 7, 2026

Uh oh!

cmsbuild commented Aug 7, 2026

Uh oh!

gabrielmscampos commented Aug 7, 2026

Uh oh!

cmsbuild commented Aug 7, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

waredjeb commented Aug 10, 2026

Uh oh!

gabrielmscampos commented Aug 12, 2026

Uh oh!

sensrcn commented Aug 13, 2026

Uh oh!

Moanwar commented Aug 17, 2026

Uh oh!

ftorrresd commented Aug 18, 2026

Uh oh!

civanch commented Aug 20, 2026

Uh oh!

cmsbuild commented Aug 20, 2026

Uh oh!

mandrenguyen commented Aug 21, 2026

Uh oh!

Uh oh!

smuzaffar commented Aug 23, 2026

Uh oh!

sbaldu commented Aug 24, 2026

Uh oh!

sbaldu commented Aug 26, 2026

Uh oh!

mmusich commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

cmsbuild commented Aug 7, 2026 •

edited

Loading