Truth Graph: Introducing Levels - #51716
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51716/50628
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
55e19f5 to
def3d28
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51716/50629
|
|
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 288KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
def3d28 to
5e70f20
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51716/50633
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51716/50682
|
|
please test |
|
+1 Size: This PR adds an extra 56KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
…utions The data model and the levels are covered by unit tests, so the prototype banner that closed the packages to external changes comes off every file that carried it.
3d45d2a to
c7bcd9c
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51716/50709 |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
|
@felicepantaleo, is this ready to reviewed & merged? It would great to have if it can still make it for CMSSW_20_1_0_pre3, so we can use if for the PF tutorial during CMS Week. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Truth levels stamped on the MC-truth logical graph, so a GEN-SIM-DIGI-RAW production ends with a final, self-describing truth graph. The reco-to-truth association layer will follow in a separate PR. Levels are flags on graph particles: the full history stays navigable, and each level marks the one particle per chain that its denominator counts (for the visible signal final state, the pi0 rather than its two photons).
Commit 1, package policy. Removes the prototype banner from every file that carried it and updates the README: the data model and the levels are now covered by unit tests. No code changes.
Commit 2,
SimDataFormats/TruthInfo:levelFlagsbitmask onParticleData, in the alignment hole sosizeofstays 96 (asserted in a unit test).ParticleRole(normal / connector / synthetic stand-in), stored as its underlying type likeVertexData::role.truth::GraphClassVersion 4 to 5,truth::ParticleData3 to 4.Commit 3,
PhysicsTools/TruthInfo, the levels. Every level is an antichain (no member is an ancestor of another); on ttbar, 24% of a kinematics-only selection had another selected particle as an ancestor, which is why a plain cut is not a denominator.PR validation:
CMSSW_20_1_0_pre2; all 9 test suites pass (19 cases inLevelFlags_t), with the association layer absent, so the split is self-contained. Workflow37634.0runs end to end on this branch alone.reconstructableFromSignaldenominator marks one entry per chain: 1137 pi0s flagged and none of their photons, no neutrinos, no intermediate resonance (rho, a1) flagged.isHardProcessparticles per event belong to the signal interaction, so the flag-driven levels are signal-only in practice; a consumer needing signal-only filters oneventIdas the denominator producer does.@IzaakWN @elenavernazza fyi