Changes needed for updatign TF to version 2.21 - #51713
Conversation
TF 2.21 marks tensorflow::Status as deprecated (ABSL_DEPRECATE_AND_INLINE), it is now an inline alias for absl::Status. Update PhysicsTools/TensorFlow, RecoTauTag/RecoTau, and RecoTracker/PixelTrackFitting to use absl::Status directly. Also comment out an unused Eigen matrix (cm2) in RiemannFit.h whose only assignment was already disabled.
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51713/50618 ERROR: Build errors found during clang-tidy run. |
|
code checks should be run with tool-conf generated via cms-sw/cmsdist#10789 . Let wait for cms-sw/cmsdist#10789 to generate the tool-conf |
|
code-checks with cms.week0.PR_cb4a0836/100.0-fcdbd34291f19a2674c959cf8ff3ed7b |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51713/50620
|
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Moanwar, @cmsbuild, @ctarricone, @gabrielmscampos, @hjkwon260, @jfernan2, @mandrenguyen, @rseidita, @srimanob, @valsdav, @y19y19 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
please test with cms-sw/cmsdist#10789 |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Failed Unit TestsI found 15 errors in the following unit tests: ---> test SagittaBiasNtuplizer had ERRORS ---> test PVValidation had ERRORS ---> test PrimaryVertex had ERRORS and more ... Comparison SummarySummary:
AMD_MI300X Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
AMD_W7900 Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 21 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_H100@cms-sw/core-l2 , I found 12 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_L40S@cms-sw/core-l2 , I found 12 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 12 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
ignore tests-rejected with external-failure unit tests failure are not related to this change. failure are already in IBs due to #51649 |
|
@cms-sw/dqm-l2 , @cms-sw/reconstruction-l2 @cms-sw/ml-l2 can you please review this PR. This is needed for Tensorflowversion 2.21.0 along with other externals needed by TF 2.21.0 ( see cms-sw/cmsdist#10789 (comment) for details). Note that there is a increase of 40-60MB for max memory used by relvals. This could easily be due to newer TF and absl version (which has far more shared libs as compare to old absl version : https://github.com/cms-sw/cmsdist/pull/10789/changes#diff-ca8f2ece019f7963a03325e0d321161afe29aecec57373401d2f4e531828a249 ). Integrating TF 2.21.0 will allow us to move forward with pythn version update too (current TF version doe snot support newer Python versions) |
|
+dqm |
|
+1 |
|
REMINDER @ftenchini, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10789, please check if they should be merged together |
|
@cms-sw/orp-l2 can we get this in 20.1.X IBs ? Once you merge it then please also sign cms-sw/cmsdist#10789 . This will allow us to move forward with TF 2.21 |
|
@cms-sw/ml-l2 ( @y19y19 ) can you please review this? This allows us to move forward with TF 2.21 integration in 20.1.X |
|
FYI @valsdav , @hjkwon260 @y19y19 , can you please review this ? |
|
+ml |
cmsbuild
added
fully-signed
ml-approved
and removed
pending-signatures
ml-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
8 participants
Tensorflow 2.21.0 related changes. These are back ported from CMSSW_20_1_TF_X branch used by special TF_X IBs