[reactor-optional] Make clean transition from reactive to async credentials provider - #3829
Open
a-TODO-rov wants to merge 1 commit into
Open
[reactor-optional] Make clean transition from reactive to async credentials provider#3829a-TODO-rov wants to merge 1 commit into
a-TODO-rov wants to merge 1 commit into
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #3785 that provides clean transition between 7.x and 8.x branches
Note
Medium Risk
Breaking public SPI renames affect any external
RedisCredentialsProviderimplementations at compile time; connection/auth behavior is otherwise unchanged.Overview
Renames the credentials provider API for a cleaner 7.x → 8.x transition:
resolveCredentials()becomesresolveCredentialsAsync(), and the nestedRedisCredentialsProvider.CredentialsSubscriptionis replaced by a top-levelSubscriptioninterface (shared handle for streaming SPIs such as credentials and the event bus).RedisCredentialsProviderjavadoc now states that failures complete the returnedCompletionStageexceptionally instead of implying a runtime throw. Implementations (StaticCredentialsProvider,TokenBasedRedisCredentialsProvider, test helpers) and internal callers (RedisHandshake,RedisAuthenticationHandler,RedisURImasking) are updated to the new names only; streaming subscribe/close behavior is unchanged.Reviewed by Cursor Bugbot for commit f558dbb. Bugbot is set up for automated code reviews on this repo. Configure here.