[reactor-optional] Deprecate reactive credentials provider - #3830
Open
a-TODO-rov wants to merge 1 commit into
Open
[reactor-optional] Deprecate reactive credentials provider#3830a-TODO-rov wants to merge 1 commit into
a-TODO-rov wants to merge 1 commit into
Conversation
atakavci
approved these changes
Jul 10, 2026
| } | ||
|
|
||
| @Test | ||
| void subscribeToCredentialsDeliversAndCloseStops() { |
Collaborator
There was a problem hiding this comment.
nit: addding another test case to see multiples succeed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3614 and #3829
Note
Low Risk
Additive API with default bridges; runtime auth paths are unchanged except deprecation annotations and new tests.
Overview
Introduces forward-compatible, non-Reactor APIs on
RedisCredentialsProviderahead of Lettuce 8.0 makingreactor-coreoptional.resolveCredentials()(Mono) andcredentials()(Flux) are deprecated since 7.7 with removal planned in 8.0. New defaults addresolveCredentialsAsync()(CompletionStage, bridged fromresolveCredentials()) andsubscribeToCredentials(onNext, onError), which returns a newSubscriptionhandle (closeable, distinct from Reactive Streams / Pub/Sub).RedisAuthenticationHandler.subscribe()is unchanged in behavior but annotated to suppress deprecation warnings while it still usescredentials(). Unit tests cover the async bridge and that closingSubscriptionstops credential delivery.Reviewed by Cursor Bugbot for commit 9b78a7a. Bugbot is set up for automated code reviews on this repo. Configure here.