[reactor-optional] Remove RedisCredentialsProvider and promote CredentialsProvider as primary - #3838
Open
a-TODO-rov wants to merge 2 commits into
Open
[reactor-optional] Remove RedisCredentialsProvider and promote CredentialsProvider as primary#3838a-TODO-rov wants to merge 2 commits into
a-TODO-rov wants to merge 2 commits into
Conversation
a-TODO-rov
changed the title
atakavci
approved these changes
Jul 13, 2026
atakavci
left a comment
atakavci
left a comment
Collaborator
There was a problem hiding this comment.
Lets address those name changes in docs as well.
Other than that, LGTM.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #3829 and follow up of #3837
Note
High Risk
This is a breaking public API change across authentication types and method names, affecting all custom credential providers and connection setup code on upgrade.
Overview
Breaking API cleanup for Redis authentication:
RedisCredentialsProvideris removed andCredentialsProviderbecomes the sole SPI, with async resolution renamed toresolveCredentialsAsync()(replacingresolveCredentials()).Streaming credential subscriptions now return a top-level
Subscriptioninterface (extracted from the old nestedCredentialsSubscription). Implementations and call sites are updated across the driver—RedisURI, handshake,RedisAuthenticationHandler,StaticCredentialsProvider, token-based auth, and tests—without changing re-auth or streaming behavior.Reviewed by Cursor Bugbot for commit 625a413. Bugbot is set up for automated code reviews on this repo. Configure here.