Expand native Mod Settings with live controls and save feedback - #282
Draft
Guffawaffle wants to merge 16 commits into
Draft
Guffawaffle wants to merge 16 commits into
Guffawaffle wants to merge 16 commits into
Conversation
This was referenced Sep 13, 2026
This was referenced Sep 19, 2026
…ion first (without held SPUD history)
…out held SPUD history)
Guffawaffle
force-pushed
the
feature/mod-settings-controls
branch
from
September 28, 2026 00:00
fa4b9cf to
fb90890
Compare
# Conflicts: # xmake.lua
# Conflicts: # mods/src/patches/patches.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds live controls under Settings → Mod Settings:
Controls share existing settings and hotkey state, show current values, and report save failures. Collapsible sections start closed. Fleet label hooks are installed at startup so visibility can change during play; partially installed hook families remain inactive.
Depends on #281 and its settings/persistence prerequisites. The shared invocation and lookup helpers are already in dev through merged #292. Supports Windows x64 and macOS through the native settings adapters.
Validation: Windows release build and settings fixtures passed. Earlier combined-build testing covered Mac ARM settings and persistence; Intel Mac and this exact upstream candidate remain without runtime qualification. Temporary probes and internal delivery/research diaries are excluded; native contract and hook evidence remain documented.