Preserve player-authored TOML for runtime setting saves - #280
Draft
Guffawaffle wants to merge 7 commits into
Draft
Guffawaffle wants to merge 7 commits into
Guffawaffle wants to merge 7 commits into
Conversation
This was referenced Sep 12, 2026
Guffawaffle
changed the title
This was referenced Sep 13, 2026
Guffawaffle
force-pushed
the
feature/preserving-toml-editor
branch
from
September 28, 2026 00:00
90f0fa3 to
6373d77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds runtime setting saves that preserve the player's TOML formatting, comments and unrelated values. Instant-warp mode is the first consumer.
A background worker coalesces changes by setting, supports slider debounce, and tracks save failures independently per key. External changes to the selected value are reported as conflicts instead of overwritten. Normal quit drains pending saves; forced exit uses a bounded best effort.
Supports booleans, strings, signed integers and finite doubles. Runtime persistence supports Windows x64 and macOS clients with compatible Unity quit signatures; unsupported bindings retain session-only changes.
Depends on #279.
macOS uses the same asynchronous writer and shutdown drain, with validated quit hooks. Fixtures cover disk reload, immediate shutdown of a debounced save, conflicts, and adapter lifecycle.
Validation: Windows release build passed. Mac ARM players confirmed settings, galaxy controls, and persistence on the combined integration build; Intel Mac runtime testing remains unconfirmed. Platform CI for this PR is tracked separately.