Add reusable native settings framework with Fleet Commander confirmation first - #277
Guffawaffle wants to merge 6 commits into
Conversation
50207df to
c09cb04
Compare
# Conflicts: # xmake.lua
|
Hook/feature alignment follow-up for #313 Follow-up to #313: keep hook installation independent of feature enablement, with default-enabled compatibility switches under This is the owning settings foundation. Settings cascade (verified from current branch ancestry): #279 → #280; #277 + #280 → #281 → #282; sibling branches from #282 are #285, #293 and #297. #285 additionally depends on #269; #297 additionally depends on #296. Correct the owning parent first, then carry the fix through every dependent branch while preserving each sibling's scope. Implemented in d024f4c; Windows release build and existing settings fixtures passed. CI is queued. Propagation through the dependent settings branches is still pending. |
Adds [MOD] Confirm Fleet Commander abilities under Settings → General → Skip Confirmation Pop-ups. ON shows confirmations; OFF skips them. The control reads and verifies the game's existing preference; opening the page does not create or save preferences.
The shared boolean-settings controller and native Windows/macOS adapter guard stale callbacks, pooled views and writes during rendering. Hook installation follows #313:
[patches].nativesettingshooksdefaults totrueand can disable the native settings hooks independently of the Fleet Commander preference, in all build modes.Validation: the corrected Windows release build, three existing settings fixtures, all 11 example TOMLs and diff checks pass. Native hook-fit and gameplay qualification for this exact artifact remain outstanding. Mac Intel/ARM builds run in CI. Shared IL2CPP helpers come from upstream #292; settings-specific metadata checks remain local to the adapter.