feat: ボトル一覧を表示した(US-3) - #34
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe bottles page now displays age, quantity, region metadata, and limited-edition badges. A reusable Badge component is added, while roadmap and US-3 documentation define the empty state and remove filtering and sorting from the current listing scope. ChangesBottle listing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/bottles/query.test.ts`:
- Around line 11-13: Add a separate assertion in the existing parseQuery test
coverage for parseQuery({}), verifying it returns the default result with no
region filter and sort set to "new"; keep the current invalid-value assertion
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3325271f-9e19-438d-b9f5-a1a8f7e81eda
📒 Files selected for processing (3)
src/app/bottles/page.tsxsrc/app/bottles/query.test.tssrc/app/bottles/query.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/app/bottles/page.tsx
3dc2f92 to
8054955
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/bottles/page.tsx`:
- Around line 47-50: Update the bottle title span in the flex row to allow
shrinking and wrapping by adding the appropriate min-width and word-wrapping
classes, while preserving the quantity span’s fixed, non-shrinking behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b3749587-6536-47ab-8d4f-5c22c6a5aee0
📒 Files selected for processing (3)
docs/user-stories.mdsrc/app/bottles/page.tsxsrc/components/ui/badge.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/ui/badge.tsx
8054955 to
26b0f0d
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
関連 issue
resolve #26
やったこと
概要
ボトル一覧ページを実装した(#25 の反映確認用の最小表示を置き換え)。読み取りは Server Component が Prisma を直接呼ぶ(アーキの鉄則どおり、クライアント JS の追加なし)。
絞り込み・並べ替えは当初 URL クエリで実装したが、一人用アプリで URL 共有の利点が薄い・実装が一覧本来の軽さに対して重い・表示要素が UI で固まっていないため YAGNI で撤去し、一覧表示に絞った。MVP のスコープから外したことを user-stories.md・roadmap.md にも反映(本文=現在形の正本)。
変更点
/bottles:一覧の本実装受け入れ条件(US-3)
動作確認
pnpm lintが通るpnpm testが通る(既存 17 本)※今回のタスクではテストを実装していない!pnpm buildが通る備考
Summary by CodeRabbit
Summary by CodeRabbit