Skip to content

docs: 第3週以降の計画を整理する - #36

Merged
hduehgw0 merged 1 commit into
mainfrom
docs/#35/plan-week3
Jul 20, 2026
Merged

docs: 第3週以降の計画を整理する#36
hduehgw0 merged 1 commit into
mainfrom
docs/#35/plan-week3

Conversation

@hduehgw0

@hduehgw0 hduehgw0 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

関連 issue

resolve #35

やったこと

概要

#26 / #34 で一覧の MVP から絞り込み・並べ替えを外し、第3週の UI 再設計へ回した。その第3週以降の計画(#34 実装中の気づき+難易度調査に基づく機能配置)をドキュメントへ反映する。

変更点

  • roadmap.md 第3週に追記:ワイヤーフレーム作成 ↔︎ ドキュメント整理/一覧の再設計(基本フィルタ〔単一軸〕・基本検索〔名前の部分一致〕・Load More ページネーション)/レスポンシブ(PC)対応(対応ストーリーに US-3 を追加)
  • user-stories.md US-3 に受け入れ条件を追記(国で絞り込み/名前で検索/「もっと見る」で追加読み込み)
  • 機能配置の整理:次点=「フィルタ・並べ替えの強化(複数軸ファセット)」に明確化、アイスボックスに「あいまい検索」「無限スクロール」を追加(requirements.md / roadmap.md
  • requirements.md 対応環境を「モバイルファースト+PC レスポンシブ対応」に更新

受け入れ条件(#35

  • roadmap.md 第3週に追記(ワイヤーフレーム/一覧再設計/レスポンシブ)
  • user-stories.md US-3 に受け入れ条件を追記
  • 次点の「フィルタ・並べ替えの強化」を “強化=複数軸ファセット” に明確化
  • アイスボックスに「あいまい検索」「無限スクロール」を追加

動作確認

  • pnpm format が通る
  • pnpm build が通る

備考

  • 機能配置:基本フィルタ/基本検索/Load More=MVP 第3週、複数軸ファセット=次点、あいまい検索/無限スクロール=アイスボックス(前提:RSC 全件取得 → client component で in-memory 操作)
  • 基本フィルタ/検索は「一覧」の細部として MVP の芯に内包(MVP 完了定義の別項目にはしない)
  • requirements.md「3. スコープ」の階層全体の組み替えは別途(スコープ外)

Summary by CodeRabbit

  • New Features

    • Defined collection browsing capabilities, including country filtering, name search, and “Load More” pagination.
    • Clarified plans for responsive, mobile-first layouts with support for current Chrome and Safari versions.
  • Documentation

    • Expanded the roadmap with dashboard, mobile UI, deployment, testing, and usability milestones.
    • Added future considerations including advanced facets, fuzzy search, infinite scrolling, wishlists, badges, and public pages.

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mycellar Ready Ready Preview, Comment Jul 20, 2026 10:58am

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

コレクション一覧の基本フィルタ・検索・Load Moreをユーザーストーリーとロードマップに反映し、複数軸ファセットや将来機能、レスポンシブ対応の要件を更新しました。

Changes

コレクション機能計画

Layer / File(s) Summary
要件スコープと対応環境
docs/requirements.md
複数軸ファセット、あいまい検索、無限スクロール、モバイルファーストのレスポンシブ対応、最新Chrome/Safariを要件に明記しました。
一覧機能の受け入れ条件
docs/user-stories.md
US-3に国による絞り込み、名前検索、「もっと見る」による追加読み込みを追加しました。
ロードマップとアイスボックス
docs/roadmap.md
第3〜4週の作業内容を具体化し、将来候補に複数軸ファセット、AI自動入力、実績バッジ、ウィッシュリストなどを追加しました。

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title succinctly describes the docs planning update and matches the main change set.
Description check ✅ Passed Description follows the template with issue, summary, changes, checklist, verification, and notes sections.
Linked Issues check ✅ Passed Changes cover #35's requested docs updates for roadmap, user stories, requirements, and feature prioritization.
Out of Scope Changes check ✅ Passed No clearly unrelated changes are present; edits stay within the requested planning-doc updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/#35/plan-week3

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
docs/requirements.md (1)

70-70: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Define a reproducible browser-support baseline.

“最新の Chrome / Safari” changes over time and does not identify mobile OS or supported major versions. State the supported browser/version policy so implementation and QA have a stable target.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/requirements.md` at line 70, Update the 対応環境 requirement in
docs/requirements.md to replace the ambiguous “latest Chrome / Safari” wording
with a reproducible browser-support policy that explicitly identifies supported
Chrome and Safari major versions and the relevant desktop/mobile operating
systems. Keep the responsive, mobile-first and PC viewing requirements
unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/requirements.md`:
- Line 36: Align the MVP scope for list features across both documents: in
docs/requirements.md at lines 36-36, explicitly include basic country filtering,
name search, and Load More in MVP while reserving multi-axis faceting for
next-point work; in docs/roadmap.md at lines 23-24, update the MVP completion
definition to include those same basic features or clearly mark them post-MVP.

In `@docs/user-stories.md`:
- Around line 37-39: Update the acceptance criteria in docs/user-stories.md for
country filtering, name search, and “もっと見る” to be testable: state that filtering
uses the fixed country list, name search performs partial matching, and define
the loading batch size, end-of-results behavior, and whether it reveals the next
in-memory batch under the documented RSC/full-fetch premise.

---

Nitpick comments:
In `@docs/requirements.md`:
- Line 70: Update the 対応環境 requirement in docs/requirements.md to replace the
ambiguous “latest Chrome / Safari” wording with a reproducible browser-support
policy that explicitly identifies supported Chrome and Safari major versions and
the relevant desktop/mobile operating systems. Keep the responsive, mobile-first
and PC viewing requirements unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c0c03ae1-00e4-40f0-9a7e-26f677320989

📥 Commits

Reviewing files that changed from the base of the PR and between d76c8ce and 7dcfde8.

📒 Files selected for processing (3)
  • docs/requirements.md
  • docs/roadmap.md
  • docs/user-stories.md

Comment thread docs/requirements.md
Comment thread docs/user-stories.md
@hduehgw0
hduehgw0 merged commit 7453043 into main Jul 20, 2026
4 checks passed
@hduehgw0
hduehgw0 deleted the docs/#35/plan-week3 branch July 20, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: 第3週以降の計画を docs に整理する

1 participant