Skip to content

refactor: 非ボタンの生カラーを semantic token に統一する - #54

Merged
hduehgw0 merged 1 commit into
mainfrom
refactor/#51/semantic-tokens
Jul 24, 2026
Merged

refactor: 非ボタンの生カラーを semantic token に統一する#54
hduehgw0 merged 1 commit into
mainfrom
refactor/#51/semantic-tokens

Conversation

@hduehgw0

@hduehgw0 hduehgw0 commented Jul 24, 2026

Copy link
Copy Markdown
Owner

関連 issue

resolve #51

やったこと

概要

#48 で扱わなかった非ボタンの生カラーを semantic token に統一した。対象は一覧の空状態と login のサブ文言の 2 箇所のみ(他に非ボタンの生カラーは無し)。ダークモード対応の前提を揃える純粋なスタイル整理。

変更点

  • 一覧の空状態 <p>src/app/bottles/page.tsx):text-gray-500text-muted-foregroundborder-gray-300 を削除(bare border が semantic --border を継承)。
  • login サブ文言 <p>src/app/login/page.tsx):text-gray-500text-muted-foreground

受け入れ条件(セルフチェック)

  • 上記の生カラーを semantic token に置換
  • semantic token へ寄せる(ダーク対応が主目的。ライト時は近似で厳密一致は非保証)
  • リポジトリ内に非ボタンの生カラーが残っていない(grep 確認)

動作確認

  • pnpm format:check
  • pnpm lint
  • pnpm test(26 本・不変)
  • pnpm build(型チェック含む)

備考

  • 空状態の border-gray-300 削除の根拠:globals.css@apply border-border により bare border は semantic --border(ダーク対応)を継承。同ファイルの一覧アイテムが既に bare border を使用しており一貫。
  • テスト追加なし(presentational・挙動不変)。

Summary by CodeRabbit

  • Style
    • Updated empty-state and login prompt text to use consistent design-system colors.
    • Improved the bottles empty-state border styling for better visual consistency.

一覧の空状態と login サブ文言に残っていた生カラーを semantic token へ。
ダークモード対応の前提を揃える。

- text-gray-500 → text-muted-foreground(一覧の空状態・login サブ文言)
- 空状態の border-gray-300 を削除(bare border が globals の border-border で
  semantic --border を継承。一覧アイテムの既存 border と一貫)
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mycellar Ready Ready Preview, Comment Jul 24, 2026 4:11pm

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52fe69c4-1b54-4663-98c7-5f16723aaee6

📥 Commits

Reviewing files that changed from the base of the PR and between 3e5f129 and 829b44e.

📒 Files selected for processing (2)
  • src/app/bottles/page.tsx
  • src/app/login/page.tsx

📝 Walkthrough

Walkthrough

Updated the bottles empty state and login prompt styling to use semantic design-system color tokens instead of gray-specific Tailwind classes.

Changes

Semantic color token updates

Layer / File(s) Summary
Update page text and border styling
src/app/bottles/page.tsx, src/app/login/page.tsx
The bottles empty-state paragraph uses semantic muted text and generic dashed border classes; the login prompt uses text-muted-foreground.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

  • hduehgw0/mycellar#48 — Covers the related semantic-color updates that were outside the referenced button-focused scope.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: consolidating non-button raw colors into semantic tokens.
Description check ✅ Passed The description follows the template well, covering issue, summary, changes, checks, testing, and notes.
Linked Issues check ✅ Passed The PR matches #51 by updating the two listed paragraphs to semantic tokens and leaving scope unchanged.
Out of Scope Changes check ✅ Passed No unrelated code changes are evident beyond the requested semantic-token refactor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#51/semantic-tokens

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands.

@hduehgw0 hduehgw0 changed the title refactor: 非ボタンの生カラーを semantic token に統一する #51 refactor: 非ボタンの生カラーを semantic token に統一する Jul 24, 2026
@hduehgw0

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@hduehgw0
hduehgw0 merged commit d03feea into main Jul 24, 2026
4 checks passed
@hduehgw0
hduehgw0 deleted the refactor/#51/semantic-tokens branch July 24, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 非ボタンの生カラーを semantic token に統一する

1 participant