Skip to content

chore(deps): record the built_collection 6.0.0 hold decision - #163

Merged
arrrrny merged 1 commit into
masterfrom
feat/issue-158
Nov 16, 2026
Merged

arrrrny merged 1 commit into
masterfrom
feat/issue-158

Conversation

@arrrrny

@arrrrny arrrrny commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

What

Issue #158 asks whether to wait for code_builder upstream to widen its
built_collection constraint, or pursue an upgrade path. Neither premise
holds
— and this PR records the corrected decision in-tree.

The issue's blocker list is wrong. Read from the resolved pub cache, the latest
releases already allow built_collection 6.0.0:

Package Latest Constraint on built_collection
code_builder 4.13.0 >=5.1.1 <7.0.0 — allows 6.0.0
build_runner 2.17.1 >=5.1.1 <7.0.0 — allows 6.0.0
build_daemon 4.1.7 >=5.0.0 <7.0.0 — allows 6.0.0
built_value 8.13.0 ^5.0.0 — blocks 6.0.0

The sole blocker is built_value, whose every published version (8.10.1 …
8.13.0) pins built_collection: ^5.0.0. Waiting on code_builder upstream
would never release the hold. The solver says so directly:

$ dart pub add "built_collection:^6.0.0" --dry-run
Because build_runner >=2.8.0 depends on built_value ^8.10.1 which depends on
built_collection ^5.0.0, build_runner >=2.8.0 requires built_collection ^5.0.0.
So, because zorphy depends on both built_collection ^6.0.0 and build_runner
^2.17.1, version solving failed.

There is no upgrade path: zorphy declares no direct built_collection
(or built_value) constraint, so there is nothing to widen here, and pinning
6.x would only make the graph unsatisfiable. 6.0.0 is also a real breaking
major — BuiltList.asList / BuiltMap.asMap now return unmodifiable views
instead of copies.

Decision: wait, and carry the unblock upstream at
google/built_value.dart#1405 rather than re-investigating code_builder on
every future release pass.

Change

A comment above code_builder: ^4.10.0 in zorphy/pubspec.yaml recording the
real blocker and the decision. That file already documents constraint reasoning
in the same voice (see the build: ">=4.0.4 <6.0.0" note above it), so the
held-upgrade note belongs there.

No lib/, generated-output, or lockfile change — zorphy/pubspec.yaml is the
only file touched, and pubspec.lock is unchanged.

Why not change a constraint

test/release/dependency_constraints_unchanged_test.dart pins every declared
constraint exactly (expect(zorphyDeps, expectedZorphyDeps)), so adding a
built_collection constraint would fail the release gate. A comment is not
parsed, so the gate is unaffected — verified below.

Test evidence

  • baseline: cd zorphy && dart test -j 2 — +374: All tests passed!
    (after cd example && dart run build_runner build --delete-conflicting-outputs, which is the fixture step CI's prepare job
    performs; without it 15 tests fail in setUpAll on missing fixtures)
  • dart pub get — Got dependencies!, zero lockfile drift
    (git diff --stat -- '*pubspec.lock' empty)
  • dart analyze lib — No issues found!
  • dart test test/release/dependency_constraints_unchanged_test.dart —
    +1: All tests passed!
  • green: cd zorphy && dart test -j 2 — +374: All tests passed!

Note: dart format --output=none --set-exit-if-changed . in zorphy reports
18 changed files, and dart analyze reports 315 issues under example/. Both
are pre-existing on master with the local Dart 3.13.7 SDK and are
unchanged by this PR (18 before, 18 after; dart analyze lib is the clean
scope). Not touched here.

Closes #158

Summary by CodeRabbit

  • Documentation
    • Added notes clarifying the dependency compatibility constraint and the decision to wait for an upstream update before changing versions.

The issue blamed code_builder 4.13.0 and the build_daemon chain, but those
already allow built_collection >=5.1.1 <7.0.0 — waiting on code_builder
upstream would never release the hold. The sole blocker is built_value
8.13.0, which pins built_collection ^5.0.0 and is reached here via
code_builder/build_runner/build_daemon.

zorphy declares no direct built_collection constraint, so there is nothing
to widen, and pinning 6.x would only make the graph unsatisfiable. Record
the decision in-tree so the next release pass does not re-chase
code_builder, with the upstream request tracked at
google/built_value.dart#1405.

Metadata only: no lib/, generated-output or lockfile change.
@arrrrny arrrrny added the chore maintenance — refactor, bump, migrate, docs, cleanup label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds comments to pubspec.yaml about the dependency constraint that blocks built_collection 6.0.0 and records the decision to wait for built_value to widen its constraint.

Changes: Dependency constraint notes

Layer / File(s) Summary
Document dependency constraints
zorphy/pubspec.yaml
Comments identify built_value 8.13.0 as the blocker, explain why pinning built_collection 6.x would prevent dependency resolution, and link tracking issues.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 74db7

This change adds documentation comments about the built_collection 6.0.0 upgrade blocker. It does not change behavior, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change accurately: it records the decision to hold built_collection 6.0.0 as a comment in zorphy/pubspec.yaml. The raw summary and objectives both confirm that pubspec.yaml is the …
Linked Issues check Passed Issue #158 asks for a decision: wait for upstream code_builder to widen built_collection, or pursue an upgrade path. The action is a dependency decision, not a coding task. No coding requirements …
Out of Scope Changes check Passed The whole-PR diff against the merge base touches only zorphy/pubspec.yaml, adding seven comment lines (+7/-0) and no code, constraint, or lockfile change. The comment directly documents the #158 dec…
Full details: Title check

Explanation

The title names the change accurately: it records the decision to hold built_collection 6.0.0 as a comment in zorphy/pubspec.yaml. The raw summary and objectives both confirm that pubspec.yaml is the only file touched and that the change adds comments only. The title is specific and concise, and it uses the conventional commit form. It does not state the blocker (built_value), but it does not need to cover every detail.

Full details: Linked Issues check

Explanation

Issue #158 asks for a decision: wait for upstream code_builder to widen built_collection, or pursue an upgrade path. The action is a dependency decision, not a coding task. No coding requirements apply. The PR records the decision (wait) as a comment above code_builder: ^4.10.0 in zorphy/pubspec.yaml, naming the blocker (built_value 8.13.0, built_collection: ^5.0.0) and the tracking link google/built_value.dart#1405. The diff confirms the change is comment-only: no dependency constraint changed. The package version claims in the PR description come from the resolved pub cache. This assessment did not re-verify them against the pub cache or registry.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against the merge base touches only zorphy/pubspec.yaml, adding seven comment lines (+7/-0) and no code, constraint, or lockfile change. The comment directly documents the #158 decision and its blocker. It supports the issue objective and is not out of scope.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f445ca73-de37-4609-8fe8-3240a78bc4b6
Commits

Reviewing files that changed from the base of the PR and between 853040e and 74db72b.

Files selected for processing: 1

  • zorphy/pubspec.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@zuraffa-review zuraffa-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR review — #163

Verdict: approve as-is. One file, seven added lines, zero behavior change — a comment block recording the built_collection 6.0.0 hold decision.

No actionable issues

I re-derived every claim in this PR independently and found no defects to fix.

Claims I verified

  • zorphy declares no direct built_collection/built_value constraint — grep on zorphy/pubspec.yaml finds only the new comment lines. The existing build: ">=4.0.4 <6.0.0" note (lines 12-13) is indeed the same voice this comment matches.
  • code_builder 4.13.0 / build_runner 2.17.1 / build_daemon 4.1.7 allow 6.0.0 — read from the resolved pub cache: >=5.1.1 <7.0.0, >=5.1.1 <7.0.0, >=5.0.0 <7.0.0. So waiting on code_builder upstream would genuinely never release the hold.
  • built_value is the sole blocker — built_value 8.13.0 (latest) pins built_collection: ^5.0.0, and the last six published versions (8.12.3 → 8.13.0) all do.
  • 6.0.0 is a real breaking major — the dart-lang/build changelog confirms BuiltList.asList, BuiltMap.asMap, BuiltListMultimap.asMap and BuiltSetMultimap.asMap now return unmodifiable views instead of copies.
  • The quoted solver error reproduces byte-for-byte — dart pub add "built_collection:^6.0.0" --dry-run fails with exactly the two lines in the PR body (build_runner >=2.8.0 requires built_collection ^5.0.0 → version solving failed).
  • The release gate is unaffected — test/release/dependency_constraints_unchanged_test.dart reads only dependencies / dev_dependencies scalar entries through package:yaml; a YAML comment is not a node, so expectedZorphyDeps still compares equal. Ran it: +1: All tests passed!
  • pubspec.lock is unchanged — dart pub get left the tracked lockfile byte-identical (git diff --numstat empty), and dart pub outdated still reports built_collection 5.1.2 → 6.0.0 as Resolvable *5.1.2, i.e. the hold is unchanged and now documented.
  • google/built_value.dart#1405 exists, is open, and is titled "built_collection 6.0.0 is blocked by the ^5.0.0 constraint" — the tracking link is correct.

Non-blocking observations (no change requested)

  • 🔵 The comment says "NOT by this constraint", but the preceding code_builder: ^4.10.0 line is what it sits above. A reader skimming line 27 first could misread which pin is meant. The wording is already unambiguous in the full sentence, so this is cosmetic only.
  • 🔵 5.1.2 is hardcoded in the comment while the resolution moves — that is a snapshot, not a defect, but it will read as stale once built_value widens. Issue #158 stays open (state: OPEN), and its Action section still offers "wait for code_builder upstream" — which this PR proves is the wrong branch. Worth a one-line correction on #158 so a future reader does not re-derive the false premise.

Verification I ran (macOS, Dart 3.13.x)

  • dart pub get → Got dependencies!, zero lockfile drift
  • dart test -j 2 test/release/dependency_constraints_unchanged_test.dart → +1: All tests passed!
  • dart test -j 2 test/release/ → +11: All tests passed!
  • dart pub add "built_collection:^6.0.0" --dry-run → reproduces the documented failure

All CI checks on the head are green (analyze, test, format, build, prepare, analyzer_compat ×2, build_runner_smoke, migrator).


Comment thread zorphy/pubspec.yaml
Comment on lines +20 to +26
# `built_collection` 5.1.2 -> 6.0.0 is held, and NOT by this constraint:
# code_builder 4.13.0 and build_daemon 4.1.7 already allow >=5.1.1 <7.0.0, so
# waiting on code_builder upstream would never release it. The sole blocker is
# built_value 8.13.0 (`built_collection: ^5.0.0`), reached here via
# code_builder/build_runner/build_daemon. Decision (issue #158): wait for
# built_value to widen rather than pin 6.x, which would make the graph
# unsatisfiable. Tracking: google/built_value.dart#1405.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵📐 Cosmetic only — no change requested. The sentence "built_collection 5.1.2 -> 6.0.0 is held, and NOT by this constraint" sits directly above code_builder: ^4.10.0 (line 27), so a reader who lands on the pin first can read "this constraint" as that one. The full sentence makes the intended meaning clear (no direct built_collection constraint exists anywhere in this file), so I would not block on it. Verified independently: built_value 8.13.0 is indeed the sole blocker, code_builder 4.13.0 / build_runner 2.17.1 / build_daemon 4.1.7 all allow 6.0.0, and the quoted solver error reproduces verbatim. The 6.0.0 breaking-change note also matches the published changelog.

@zuraffa-review

Copy link
Copy Markdown
Contributor

Walkthrough — PR review 163 (arrrrny/zorphy)

Head reviewed: 74db72b911638b78d74248fca029604278acd488 — "chore(deps): record the built_collection 6.0.0 hold decision" on feat/issue-158 → master. Mergeability checked first: MERGEABLE / UNSTABLE (checks still running, not conflicting).

Scope: 1 file, +7 / -0 — a comment block above code_builder: ^4.10.0 in zorphy/pubspec.yaml. No lib/, no generated output, no lockfile change.

Verdict: No actionable issues — approve as-is.

How I verified it

Rather than take the comment's word for it, I re-derived the whole dependency story from the resolved pub cache and the published changelogs:

Check Result
Does zorphy declare built_collection? No — grep on zorphy/pubspec.yaml hits only the new comment lines. "NOT by this constraint" is accurate.
code_builder 4.13.0 constraint >=5.1.1 <7.0.0 — allows 6.0.0
build_runner 2.17.1 >=5.1.1 <7.0.0 — allows 6.0.0
build_daemon 4.1.7 >=5.0.0 <7.0.0 — allows 6.0.0
built_value 8.13.0 (latest) ^5.0.0 — the sole blocker; same for the last six published versions
6.0.0 is breaking? Yes — asList/asMap now return unmodifiable views, not copies
Quoted solver error Reproduced byte-for-byte: dart pub add "built_collection:^6.0.0" --dry-run → the same two lines
Release gate unaffected? Yes — dependency_constraints_unchanged_test.dart reads only scalar dep entries via package:yaml; a comment is not a node. +11: All tests passed!
pubspec.lock drift None — dart pub get left the tracked lockfile byte-identical
Upstream tracking issue google/built_value.dart#1405 exists, open, correctly titled

Tests run on this head (macOS, Dart 3.13.x, /tmp clone): dart pub get → Got dependencies!; dart test -j 2 test/release/ → +11: All tests passed!; dart pub outdated still shows built_collection 5.1.2 → 6.0.0 as Resolvable *5.1.2 — i.e. the hold is exactly where the comment says it is.

CI: all checks green on the head (analyze, test, format, build, prepare, analyzer_compat ×2, build_runner_smoke, migrator). This bot's own review check is the one pending entry.

Non-blocking notes (no change requested)

@arrrrny arrrrny closed this Nov 16, 2026
@arrrrny arrrrny reopened this Nov 16, 2026
@arrrrny
arrrrny merged commit 13a95c4 into master Nov 16, 2026
18 checks passed
@arrrrny

arrrrny commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Merge task

merged as 13a95c4b (Merge pull request #163 from arrrrny/feat/issue-158)

Note: the merge itself hit a stale GitHub-side merge lock — REST PUT /pulls/163/merge and GraphQL both answered 405 Merge already in progress while refs/heads/master never moved. Closing and reopening the PR cleared it; the retry merged.

Separate pre-existing base problem, unrelated to this PR's one-comment diff and filed for the pool: Dart CI (push) has been red on every master commit since 58f07bc6 because its analyzer_compat step omits the zorphy_annotation: path: ../zorphy_annotation override that ci.yaml carries — tracked as #164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore maintenance — refactor, bump, migrate, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): built_collection 6.0.0 available — held by transitive constraint (code_builder)

1 participant