Skip to content

chore(deps): take the upgrades left by the 3.0.0 release - #168

Merged
arrrrny merged 1 commit into
masterfrom
feat/issue-167
Nov 17, 2026
Merged

arrrrny merged 1 commit into
masterfrom
feat/issue-167

Conversation

@arrrrny

@arrrrny arrrrny commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

What

Takes the dependency upgrades the 3.0.0 release left on the table (issue #167),
per the dependency-bump rule in AGENTS.md.

  • zorphy_migrator: raise dev_dependencies.test from ^1.31.1 to
    ^1.33.0 and re-resolve pubspec.lock, which pulls the resolvable
    patch/minor bumps: test 1.31.2→1.33.0, test_api 0.7.13→0.7.15,
    test_core 0.6.19→0.6.21, clock 1.1.2→1.1.3, crypto 3.0.7→3.0.8,
    glob 2.1.3→2.2.0, pub_semver 2.2.0→2.2.1, stack_trace 1.12.1→1.12.2,
    yaml 3.1.3→3.1.4, plus the dev-transitive bumps (coverage 1.16.0,
    vm_service 15.4.0, frontend_server_client 4.2.0, source_maps 0.10.14,
    http_multi_server 3.2.3, shelf 1.4.3, shelf_static 1.2.0, io 1.1.0,
    mime 2.1.0, pool 1.5.3, web 1.1.2, new cli_util 0.6.0 / ffi 2.2.0).

zorphy and zorphy_annotation already resolve every direct/transitive
dependency at the newest version their constraints allow — their lockfiles are
untouched (only built_collection is held, see below).

built_collection 6.0.0 stays held. It is a breaking major and is not held
by our own constraint: code_builder/build_runner/build_daemon already allow
>=5.1.1 <7.0.0, but built_value (8.13.0) pins built_collection: ^5.0.0, so
6.x makes the graph unsatisfiable. The hold and the upstream issue
(google/built_value.dart#1405) are already recorded in zorphy/pubspec.yaml
(chore(deps) #163); this PR does not change that decision.

The zorphy_annotation 2.4.6 row in the issue's pub outdated table is the
local path override (pubspec_overrides.yaml → ../zorphy_annotation at 3.0.0),
not a real lag — left as-is.

Test evidence

  • dart format --output=none --set-exit-if-changed . (zorphy) — Formatted 233 files (0 changed)
  • dart analyze — zorphy: No issues found!; zorphy_annotation: No issues found!; zorphy_migrator: No issues found!
  • dart test -j 2 (zorphy) — 374 tests, All tests passed!
  • dart test -j 2 (zorphy_migrator) — 45 tests, All tests passed!
  • ./scripts/local_ci.sh — 34 step(s) ran, ... 0 failed (exit 0)

Closes #167

Summary by CodeRabbit

  • Chores
    • Updated project development configuration. This maintenance change does not alter the app’s features, workflows, or user-facing behavior. No new capabilities or user-facing fixes are included in this update.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The zorphy_migrator package raises its test dev dependency constraint from ^1.31.1 to ^1.33.0.

Changes: Test Dependency Update

Layer / File(s) Summary
Update the test dependency constraint
zorphy_migrator/pubspec.yaml
The test dev dependency constraint changes from ^1.31.1 to ^1.33.0.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: chore

Merge Risk: Minimal · up to f220d

This updates a test-only dependency constraint and does not change runtime behavior. The reported gates pass, so the merge risk is minimal.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive [#167] Requirement 1, raise zorphy_migrator dev_dependencies.test from ^1.31.1 to ^1.33.0: PASS. The raw summary of zorphy_migrator/pubspec.yaml shows this one-line change. [#167] Requiremen… Provide reviewable evidence of the zorphy_migrator/pubspec.lock contents at the reviewed head, or confirm that it resolves the versions listed in the PR description. The lockfile path is excluded by the !**/*.lock rule, and no inclusion…
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names a dependency-maintenance change ("take the upgrades left by the 3.0.0 release"). The changeset raises the zorphy_migrator test dev dependency from ^1.31.1 to ^1.33.0, and the linked ob…
Out of Scope Changes check Passed The reviewable change is the single zorphy_migrator/pubspec.yaml edit that raises the test dev dependency constraint. This edit directly implements [#167]. The PR description and objectives list n…
Full details: Title check

Explanation

The title names a dependency-maintenance change ("take the upgrades left by the 3.0.0 release"). The changeset raises the zorphy_migrator test dev dependency from ^1.31.1 to ^1.33.0, and the linked objectives describe re-resolving lockfiles for patch/minor bumps. The title is specific enough, though it does not name the test dependency or say that built_collection stays on 5.x.

Full details: Out of Scope Changes check

Explanation

The reviewable change is the single zorphy_migrator/pubspec.yaml edit that raises the test dev dependency constraint. This edit directly implements [#167]. The PR description and objectives list no other source, test, or documentation changes. The lockfile change (zorphy_migrator/pubspec.lock) is excluded from review, so its contents were not inspected. Its stated purpose, re-resolving for the patch/minor bumps listed in [#167], is within scope. No demonstrated unrelated change was found.

Full details: Linked Issues check

Explanation

[#167] Requirement 1, raise zorphy_migrator dev_dependencies.test from ^1.31.1 to ^1.33.0: PASS. The raw summary of zorphy_migrator/pubspec.yaml shows this one-line change. [#167] Requirement 2, re-resolve lockfiles for the patch/minor bumps: INCONCLUSIVE. The only lockfile in scope, zorphy_migrator/pubspec.lock, is in ignored_files (excluded by rule !**/*.lock, with no inclusion rule). Its contents were not reviewed, so the listed resolved versions (test 1.33.0, test_api 0.7.15, clock 1.1.3, and others) cannot be confirmed from reviewable evidence. [#167] Requirement 3, rerun dart test -j 2 and the gates: the PR description reports passing results (zorphy 374 tests, zorphy_migrator 45 tests, local_ci.sh 0 failed). These are author-reported and were not independently verified. The built_collection hold is a documented decision with no code change required. The zorphy_annotation override row needs no change, per the issue.

Resolution

Provide reviewable evidence of the zorphy_migrator/pubspec.lock contents at the reviewed head, or confirm that it resolves the versions listed in the PR description. The lockfile path is excluded by the !**/*.lock rule, and no inclusion rule applies. Independent evidence of a passing dart test -j 2 run for zorphy_migrator would also close the test requirement.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d763a83-276a-41b9-9a97-38848a68e92b
Commits

Reviewing files that changed from the base of the PR and between 7c2b565 and f220de5.

Files ignored due to path filters: 1

  • zorphy_migrator/pubspec.lock is excluded by !**/*.lock
Files selected for processing: 1

  • zorphy_migrator/pubspec.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@arrrrny arrrrny added the chore maintenance — refactor, bump, migrate, docs, cleanup label Nov 17, 2026

@zuraffa-review zuraffa-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit-style review — clean

🟢 Verdict: No actionable issues

What this PR does

Raises zorphy_migrator's dev_dependencies.test from ^1.31.1 to ^1.33.0 and re-resolves zorphy_migrator/pubspec.lock, taking the resolvable patch/minor bumps the 3.0.0 release left on the table: 20 forward bumps, no downgrades, no removals, plus two new dev-transitive packages (cli_util 0.6.0, ffi 2.2.0 via coverage).

Verification — run in a task-scoped /tmp clone at f220de5

Check Result
rm pubspec.lock && dart pub get reproduces the committed lock byte-for-byte — no resolution drift
lock sha256 vs pub.dev archive_sha256 56/56 match, 0 mismatches
lock diff vs base f220de5^ 20 bumps · 0 downgrades · 0 removed · 2 added (cli_util, ffi)
dart analyze (zorphy_migrator) No issues found!
dart test -j 2 (zorphy_migrator) 45 tests, All tests passed!
dart pub outdated (zorphy_migrator) dev_dependencies: all up-to-date.
dart pub outdated (zorphy) only the documented built_collection 5.1.2 → 6.0.0 hold
mergeability MERGEABLE — no conflict pass needed

The PR's claim that zorphy / zorphy_annotation needed no bump holds up: their committed locks already resolve at the newest version their constraints allow (test 1.33.0, glob 2.2.0, yaml 3.1.4, pub_semver 2.2.1).

🔵 Informational (no action requested)

  • zorphy_migrator/pubspec.lock:60 and :116 — cli_util / ffi are new dev-transitive entries pulled in by coverage 1.16.0. Dev-only, so consumers of the CLI see no change.
  • zorphy_migrator/pubspec.yaml:21 — leaving zorphy/pubspec.yaml untouched is correct here. Its declared constraints (glob: ^2.1.2, test: ^1.31.1, yaml: ^3.1.3, pub_semver: ^2.2.0) are deliberately frozen by zorphy/test/release/dependency_constraints_unchanged_test.dart, so widening them would be a release-contract change rather than a dependency bump.
  • The zorphy_annotation 3.0.0 (overridden) → 2.4.6 row that dart pub outdated prints is the local pubspec_overrides.yaml path override, not a real lag.

Agent prompt

No fixes needed — safe to merge when the pool's merge task runs.

@zuraffa-review

Copy link
Copy Markdown
Contributor

Review walkthrough — chore(deps): take the upgrades left by the 3.0.0 release

Scope: 2 files, +57 / −41. zorphy_migrator/pubspec.yaml raises dev_dependencies.test ^1.31.1 → ^1.33.0; zorphy_migrator/pubspec.lock is the re-resolve (20 forward bumps, 2 new dev-transitive entries, no downgrades, no removals).

How I verified it (fresh /tmp clone pinned to f220de5, shared pub cache — no shared checkout touched):

  1. Reproducibility. rm pubspec.lock && dart pub get regenerated a lock identical to the committed one — the PR's lock is exactly what a clean resolve produces, which is the property the repo's own dependency-bump rule depends on. Same for the sdks: block, so nothing there is stale either.
  2. Hash integrity. Every sha256 in the lock (56 packages) was compared against pub.dev's archive_sha256. 56/56 match — a fresh machine or CI cannot hit a checksum error.
  3. Diff hygiene vs base f220de5^. No package removed, no version moved backwards, no dependency-kind changes (direct/transitive). The two additions are cli_util 0.6.0 and ffi 2.2.0, both dev-only via coverage 1.16.0 ← test.
  4. Gates. dart analyze → No issues found!; dart test -j 2 → 45 tests, all passed; dart pub outdated → dev_dependencies: all up-to-date.
  5. The "no other bump needed" claim. Checked, and it is true: zorphy's and zorphy_annotation's committed locks already resolve at the newest allowed versions (test 1.33.0, glob 2.2.0, yaml 3.1.4, pub_semver 2.2.1), and the only thing dart pub outdated still holds in zorphy is the already-documented built_collection 5.1.2 → 6.0.0 (blocked upstream by built_value 8.13.0, built_collection 6.0.0 is blocked by the ^5.0.0 constraint google/built_value.dart#1405).
  6. Mergeability. mergeable: MERGEABLE — no conflict resolution was needed, so nothing was pushed to the branch.

Two things worth recording (🔵, no action requested):

  • Leaving zorphy/pubspec.yaml alone is the right call here, not an oversight. Its declared constraints are deliberately frozen by zorphy/test/release/dependency_constraints_unchanged_test.dart, so widening them would be a release-contract change, not a dependency bump.
  • The zorphy_annotation 3.0.0 (overridden) → 2.4.6 line in dart pub outdated is the local pubspec_overrides.yaml path override, not a lag.

Verdict: clean — no actionable issues. The review is posted as zuraffa-review[bot], commit-pinned to f220de5.

@arrrrny
arrrrny merged commit a742654 into master Nov 17, 2026
13 checks passed
@arrrrny

arrrrny commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Merge task

merged as a742654 — chore(deps): take the upgrades left by the 3.0.0 release (#167).

  • Readiness gate: 0 actionable reviewer findings (review comments 0, reviews 0) → clean pass, no fixes round needed.
  • CI gate (public repo, §4U): all checks SUCCESS — version_sync, build, format, prepare, migrator, analyze, test, build_runner_smoke, analyzer_compat (13)/(14), CodeRabbit, zuraffa-review; deploy SKIPPED (expected on a PR). Nothing pending, nothing red.
  • Mergeability: MERGEABLE / CLEAN at head f220de5 — no conflict resolution needed.
  • Linked issue chore(deps): upgrades left on the table by the 3.0.0 release #167 verified as an issue (not a PR) and already closed automatically by the merge into the default branch master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore maintenance — refactor, bump, migrate, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): upgrades left on the table by the 3.0.0 release

1 participant