Repository navigation
chore(deps): take the upgrades left by the 3.0.0 release - #168
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
CodeRabbit-style review — clean
🟢 Verdict: No actionable issues
What this PR does
Raises zorphy_migrator's dev_dependencies.test from ^1.31.1 to ^1.33.0 and re-resolves zorphy_migrator/pubspec.lock, taking the resolvable patch/minor bumps the 3.0.0 release left on the table: 20 forward bumps, no downgrades, no removals, plus two new dev-transitive packages (cli_util 0.6.0, ffi 2.2.0 via coverage).
Verification — run in a task-scoped /tmp clone at f220de5
| Check | Result |
|---|---|
rm pubspec.lock && dart pub get |
reproduces the committed lock byte-for-byte — no resolution drift |
lock sha256 vs pub.dev archive_sha256 |
56/56 match, 0 mismatches |
lock diff vs base f220de5^ |
20 bumps · 0 downgrades · 0 removed · 2 added (cli_util, ffi) |
dart analyze (zorphy_migrator) |
No issues found! |
dart test -j 2 (zorphy_migrator) |
45 tests, All tests passed! |
dart pub outdated (zorphy_migrator) |
dev_dependencies: all up-to-date. |
dart pub outdated (zorphy) |
only the documented built_collection 5.1.2 → 6.0.0 hold |
| mergeability | MERGEABLE — no conflict pass needed |
The PR's claim that zorphy / zorphy_annotation needed no bump holds up: their committed locks already resolve at the newest version their constraints allow (test 1.33.0, glob 2.2.0, yaml 3.1.4, pub_semver 2.2.1).
🔵 Informational (no action requested)
zorphy_migrator/pubspec.lock:60and:116—cli_util/ffiare new dev-transitive entries pulled in bycoverage 1.16.0. Dev-only, so consumers of the CLI see no change.zorphy_migrator/pubspec.yaml:21— leavingzorphy/pubspec.yamluntouched is correct here. Its declared constraints (glob: ^2.1.2,test: ^1.31.1,yaml: ^3.1.3,pub_semver: ^2.2.0) are deliberately frozen byzorphy/test/release/dependency_constraints_unchanged_test.dart, so widening them would be a release-contract change rather than a dependency bump.- The
zorphy_annotation 3.0.0 (overridden) → 2.4.6row thatdart pub outdatedprints is the localpubspec_overrides.yamlpath override, not a real lag.
Agent prompt
No fixes needed — safe to merge when the pool's merge task runs.
Review walkthrough —
|
Merge taskmerged as a742654 — chore(deps): take the upgrades left by the 3.0.0 release (#167).
|
What
Takes the dependency upgrades the 3.0.0 release left on the table (issue #167),
per the dependency-bump rule in
AGENTS.md.zorphy_migrator: raisedev_dependencies.testfrom^1.31.1to^1.33.0and re-resolvepubspec.lock, which pulls the resolvablepatch/minor bumps:
test1.31.2→1.33.0,test_api0.7.13→0.7.15,test_core0.6.19→0.6.21,clock1.1.2→1.1.3,crypto3.0.7→3.0.8,glob2.1.3→2.2.0,pub_semver2.2.0→2.2.1,stack_trace1.12.1→1.12.2,yaml3.1.3→3.1.4, plus the dev-transitive bumps (coverage1.16.0,vm_service15.4.0,frontend_server_client4.2.0,source_maps0.10.14,http_multi_server3.2.3,shelf1.4.3,shelf_static1.2.0,io1.1.0,mime2.1.0,pool1.5.3,web1.1.2, newcli_util0.6.0 /ffi2.2.0).zorphyandzorphy_annotationalready resolve every direct/transitivedependency at the newest version their constraints allow — their lockfiles are
untouched (only
built_collectionis held, see below).built_collection6.0.0 stays held. It is a breaking major and is not heldby our own constraint:
code_builder/build_runner/build_daemonalready allow>=5.1.1 <7.0.0, butbuilt_value(8.13.0) pinsbuilt_collection: ^5.0.0, so6.x makes the graph unsatisfiable. The hold and the upstream issue
(google/built_value.dart#1405) are already recorded in
zorphy/pubspec.yaml(chore(deps) #163); this PR does not change that decision.
The
zorphy_annotation 2.4.6row in the issue'spub outdatedtable is thelocal path override (
pubspec_overrides.yaml→../zorphy_annotationat 3.0.0),not a real lag — left as-is.
Test evidence
dart format --output=none --set-exit-if-changed .(zorphy) —Formatted 233 files (0 changed)dart analyze— zorphy:No issues found!; zorphy_annotation:No issues found!; zorphy_migrator:No issues found!dart test -j 2(zorphy) —374tests,All tests passed!dart test -j 2(zorphy_migrator) —45tests,All tests passed!./scripts/local_ci.sh—34 step(s) ran, ... 0 failed(exit 0)Closes #167
Summary by CodeRabbit