Repository navigation
chore(deps): run on built_collection 6.0.0 via a git override - #169
Conversation
…ilt_value release built_value 8.13.0 pins built_collection ^5.0.0 and is the only thing holding the graph on 5.x -- code_builder 4.13.0, build_runner 2.17.1 and build_daemon 4.1.7 already declare >=5.1.1 <7.0.0. Rather than wait for a release, point the development override at the widening branch (google/built_value.dart#1406) so the package and its tests exercise 6.0.0 today. - zorphy/pubspec_overrides.yaml: built_value -> git arrrrny/built_value.dart @ widen-built-collection-1405. - zorphy/pubspec.lock: built_collection 5.1.2 -> 6.0.0. - zorphy/pubspec.yaml: replace the stale 'held' comment with the real state and the removal step. Development-only: pub ignores pubspec_overrides.yaml, so consumers resolve whatever built_value allows. Nothing changes for them either way; when built_value publishes the widening, delete the override and re-resolve. Verified on the 6.0.0 graph: dart analyze clean, 374/374 tests, and the example still builds 178 outputs and analyzes clean. built_collection 6.0.0 makes asList/asMap return unmodifiable views; zorphy never calls them. Refs #167, google/built_value.dart#1405.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
Review — chore(deps): built_collection 6.0.0 via git override
Clean, well-documented development-only dependency change. I verified the graph actually resolves and the shipped package is unaffected. No actionable issues.
Verification performed
built_collection 6.0.0confirmed on pub.dev (latest; published 2026-10-26). The lock'ssha256(68c430b…) matches pub.dev'sarchive_sha256exactly.- The override's
git.refbranch head (afeb2eb…) equals the lock'sresolved-ref— reproducible. - That branch widens
built_value's constraint tobuilt_collection: '>=5.1.1 <7.0.0'. dart pub getresolves cleanly (built_value 8.13.0from git atafeb2e;built_collectionhosted) with no lock drift — the committed lock is stable.dart analyze lib→ No issues found (shipped source clean). Theexample/analyzer errors are pre-existing and codegen-gated (needbuild_runner; this PR changes 0 example files).- Consumers unaffected:
pubspec_overrides.yamlis ignored on publish, confirmed by the author's--dry-run.
Notes (🔵 non-blocking)
- 🔵 The override pins a mutable branch name in a personal fork; CI now fetches
arrrrny/built_value.dartat build time. The committedresolved-refkeepspub getreproducible, but adart pub upgrade/ deleted lock would re-resolve the branch head. Fine for a dev-only gate — removing the block oncebuilt_valuepublishes the widening (as the comment notes) closes it. - 🔵 Minor comment wording differs between the two files (
pubspec_overrides.yaml"is in" vspubspec.yaml"is proposed in"). See inline.
No actionable issues.
| built_value: | ||
| git: | ||
| url: https://github.com/arrrrny/built_value.dart | ||
| ref: widen-built-collection-1405 |
There was a problem hiding this comment.
🔵 Non-blocking (📐 maintainability): ref is a mutable branch name in a personal fork, so CI now fetches arrrrny/built_value.dart at build time, and a dart pub upgrade (or a deleted lock) re-resolves the branch head. The committed resolved-ref: afeb2eb… keeps pub get reproducible, so this is fine for a development-only gate — just note the override's stability depends on that fork/branch staying put. Deleting this block once built_value publishes the widening (as the comment says) closes it.
| zorphy_annotation: | ||
| path: ../zorphy_annotation | ||
| # built_value 8.13.0 still pins built_collection ^5.0.0, which is the sole | ||
| # blocker for 6.0.0 (google/built_value.dart#1405). The widening is in |
There was a problem hiding this comment.
🔵 Nit (📐 clarity): here it reads "The widening is in google/built_value.dart#1406" (present tense, as if already merged), while pubspec.yaml correctly says "is proposed in". The branch itself says "Fixes #1405" and the PR is #1406. Consider e.g. "proposed in #1406 (branch widen-built-collection-1405, fixes #1405)" to keep the cross-references unambiguous.
|
Walkthrough — review of Nice, tidy change. I verified it end-to-end rather than taking the description on trust:
Verdict: No actionable issues. Two 🔵 non-blocking notes inline (mutable branch ref in the override; a wording nit in the override comment). The follow-up to drop the override once |
Merge taskmerged as d9360d8 Readiness gate (§2): 0 actionable reviewer findings — the two CI gate (§4U, public repo): every No linked issues ( |
Runs the package and its test suite on
built_collection6.0.0 now, instead of waiting for abuilt_valuerelease.Why a git reference
built_value8.13.0 pinsbuilt_collection: ^5.0.0, and it is the only remaining blocker —code_builder4.13.0,build_runner2.17.1 andbuild_daemon4.1.7 all already declare>=5.1.1 <7.0.0. Waiting for a release leaves the graph on 5.x indefinitely; the widening is proposed upstream in google/built_value.dart#1406 and lands here as a development-only override.Changes
zorphy/pubspec_overrides.yaml—built_valueresolved from git atarrrrny/built_value.dart@widen-built-collection-1405(the branch carrying the one-line widening).zorphy/pubspec.lock—built_collection5.1.2 → 6.0.0.zorphy/pubspec.yaml— the stale "held / waiting" comment is replaced with the actual state and the removal step.Scope and safety
pubspec_overrides.yamlis a development-only file thatpubignores on publish, so consumers see no change at all — they resolve whateverbuilt_valueallows, exactly as before. This is a CI-and-local gate change, not a published constraint change.When
built_valuepublishes the widening, the follow-up is one step: delete thebuilt_valueblock frompubspec_overrides.yamland re-resolve, which puts the lock back on hosted sources. That is recorded in thepubspec.yamlcomment and on #167.Verification on the 6.0.0 graph
dart pub depsbuilt_collection 6.0.0,built_value 8.13.0from gitdart analyze .dart test -j 2zorphy/examplebuilddart pub publish --dry-runThe 6.0.0 behaviour change
built_collection6.0.0 makesBuiltList.asList,BuiltMap.asMap,BuiltListMultimap.asMapandBuiltSetMultimap.asMapreturn unmodifiable views instead of copies. zorphy's own source never importsbuilt_collectionor calls those accessors — it reaches the package only transitively throughcode_builder/build_runner/build_daemon— and all 374 tests pass against 6.0.0.Not in this PR:
zorphy/examplestill resolvesbuilt_collection5.1.2, because its committed lock pins oldercode_builder4.11.1 /build_daemon4.1.5 that cap the range. Moving the example onto 6.0.0 means upgrading that pinned dev set, which is a separate chore (#167).Refs #167, google/built_value.dart#1405.
Summary by CodeRabbit
built_collectionrelease. The override applies only during development and does not affect package consumers.