Skip to content

chore(deps): run on built_collection 6.0.0 via a git override - #169

Merged
arrrrny merged 1 commit into
masterfrom
built-collection-6
Nov 17, 2026
Merged

arrrrny merged 1 commit into
masterfrom
built-collection-6

Conversation

@arrrrny

@arrrrny arrrrny commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Runs the package and its test suite on built_collection 6.0.0 now, instead of waiting for a built_value release.

Why a git reference

built_value 8.13.0 pins built_collection: ^5.0.0, and it is the only remaining blocker — code_builder 4.13.0, build_runner 2.17.1 and build_daemon 4.1.7 all already declare >=5.1.1 <7.0.0. Waiting for a release leaves the graph on 5.x indefinitely; the widening is proposed upstream in google/built_value.dart#1406 and lands here as a development-only override.

Changes

  • zorphy/pubspec_overrides.yaml — built_value resolved from git at arrrrny/built_value.dart@widen-built-collection-1405 (the branch carrying the one-line widening).
  • zorphy/pubspec.lock — built_collection 5.1.2 → 6.0.0.
  • zorphy/pubspec.yaml — the stale "held / waiting" comment is replaced with the actual state and the removal step.

Scope and safety

pubspec_overrides.yaml is a development-only file that pub ignores on publish, so consumers see no change at all — they resolve whatever built_value allows, exactly as before. This is a CI-and-local gate change, not a published constraint change.

When built_value publishes the widening, the follow-up is one step: delete the built_value block from pubspec_overrides.yaml and re-resolve, which puts the lock back on hosted sources. That is recorded in the pubspec.yaml comment and on #167.

Verification on the 6.0.0 graph

Check Result
dart pub deps built_collection 6.0.0, built_value 8.13.0 from git
dart analyze . clean
dart test -j 2 374/374
zorphy/example build 178 outputs, 71 shared parts, analyze clean
dart pub publish --dry-run passes (warnings only: pre-existing gitignore/layout/override hints)

The 6.0.0 behaviour change

built_collection 6.0.0 makes BuiltList.asList, BuiltMap.asMap, BuiltListMultimap.asMap and BuiltSetMultimap.asMap return unmodifiable views instead of copies. zorphy's own source never imports built_collection or calls those accessors — it reaches the package only transitively through code_builder / build_runner / build_daemon — and all 374 tests pass against 6.0.0.

Not in this PR: zorphy/example still resolves built_collection 5.1.2, because its committed lock pins older code_builder 4.11.1 / build_daemon 4.1.5 that cap the range. Moving the example onto 6.0.0 means upgrading that pinned dev set, which is a separate chore (#167).

Refs #167, google/built_value.dart#1405.

Summary by CodeRabbit

  • Chores
    • Updated development dependency configuration for compatibility testing with a newer built_collection release. The override applies only during development and does not affect package consumers.

…ilt_value release

built_value 8.13.0 pins built_collection ^5.0.0 and is the only thing
holding the graph on 5.x -- code_builder 4.13.0, build_runner 2.17.1 and
build_daemon 4.1.7 already declare >=5.1.1 <7.0.0. Rather than wait for a
release, point the development override at the widening branch
(google/built_value.dart#1406) so the package and its tests exercise 6.0.0
today.

- zorphy/pubspec_overrides.yaml: built_value -> git
  arrrrny/built_value.dart @ widen-built-collection-1405.
- zorphy/pubspec.lock: built_collection 5.1.2 -> 6.0.0.
- zorphy/pubspec.yaml: replace the stale 'held' comment with the real state
  and the removal step.

Development-only: pub ignores pubspec_overrides.yaml, so consumers resolve
whatever built_value allows. Nothing changes for them either way; when
built_value publishes the widening, delete the override and re-resolve.

Verified on the 6.0.0 graph: dart analyze clean, 374/374 tests, and the
example still builds 178 outputs and analyzes clean. built_collection 6.0.0
makes asList/asMap return unmodifiable views; zorphy never calls them.

Refs #167, google/built_value.dart#1405.
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The dependency comment now describes built_value as the remaining constraint on built_collection 6.0.0. The overrides file adds a Git dependency override for built_value and documents its development-only use.

Changes: built_value development override

Layer / File(s) Summary
Document and configure the override
zorphy/pubspec.yaml, zorphy/pubspec_overrides.yaml
The dependency comment describes the built_value constraint and when to remove the override. The overrides file adds a Git dependency using the widen-built-collection-1405 ref and the built_value subdirectory.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • arrrrny/zorphy#168: Both PRs address the built_value constraint that prevents built_collection 6.0.0.
  • arrrrny/zorphy#163: This PR revises the dependency comment and adds an override related to the upstream change documented in that PR.

Suggested labels: chore

Merge Risk: Minimal · up to aef63

This change only affects local development and test dependency resolution, not consumers of the package. No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the dependency change (running zorphy against built_collection 6.0.0 through a git override), which is the main change in the summary and objectives. The title uses the conventional co…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the dependency change (running zorphy against built_collection 6.0.0 through a git override), which is the main change in the summary and objectives. The title uses the conventional commit prefix chore(deps). It is specific and accurate, so it passes.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d010920d-4e50-468e-a7ef-2907e6df5f7f
Commits

Reviewing files that changed from the base of the PR and between a742654 and aef63d6.

Files ignored due to path filters: 1

  • zorphy/pubspec.lock is excluded by !**/*.lock
Files selected for processing: 2

  • zorphy/pubspec.yaml
  • zorphy/pubspec_overrides.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@arrrrny arrrrny added the chore maintenance — refactor, bump, migrate, docs, cleanup label Nov 17, 2026

@zuraffa-review zuraffa-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — chore(deps): built_collection 6.0.0 via git override

Clean, well-documented development-only dependency change. I verified the graph actually resolves and the shipped package is unaffected. No actionable issues.

Verification performed

  • built_collection 6.0.0 confirmed on pub.dev (latest; published 2026-10-26). The lock's sha256 (68c430b…) matches pub.dev's archive_sha256 exactly.
  • The override's git.ref branch head (afeb2eb…) equals the lock's resolved-ref — reproducible.
  • That branch widens built_value's constraint to built_collection: '>=5.1.1 <7.0.0'.
  • dart pub get resolves cleanly (built_value 8.13.0 from git at afeb2e; built_collection hosted) with no lock drift — the committed lock is stable.
  • dart analyze lib → No issues found (shipped source clean). The example/ analyzer errors are pre-existing and codegen-gated (need build_runner; this PR changes 0 example files).
  • Consumers unaffected: pubspec_overrides.yaml is ignored on publish, confirmed by the author's --dry-run.

Notes (🔵 non-blocking)

  • 🔵 The override pins a mutable branch name in a personal fork; CI now fetches arrrrny/built_value.dart at build time. The committed resolved-ref keeps pub get reproducible, but a dart pub upgrade / deleted lock would re-resolve the branch head. Fine for a dev-only gate — removing the block once built_value publishes the widening (as the comment notes) closes it.
  • 🔵 Minor comment wording differs between the two files (pubspec_overrides.yaml "is in" vs pubspec.yaml "is proposed in"). See inline.

No actionable issues.

built_value:
git:
url: https://github.com/arrrrny/built_value.dart
ref: widen-built-collection-1405

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Non-blocking (📐 maintainability): ref is a mutable branch name in a personal fork, so CI now fetches arrrrny/built_value.dart at build time, and a dart pub upgrade (or a deleted lock) re-resolves the branch head. The committed resolved-ref: afeb2eb… keeps pub get reproducible, so this is fine for a development-only gate — just note the override's stability depends on that fork/branch staying put. Deleting this block once built_value publishes the widening (as the comment says) closes it.

zorphy_annotation:
path: ../zorphy_annotation
# built_value 8.13.0 still pins built_collection ^5.0.0, which is the sole
# blocker for 6.0.0 (google/built_value.dart#1405). The widening is in

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Nit (📐 clarity): here it reads "The widening is in google/built_value.dart#1406" (present tense, as if already merged), while pubspec.yaml correctly says "is proposed in". The branch itself says "Fixes #1405" and the PR is #1406. Consider e.g. "proposed in #1406 (branch widen-built-collection-1405, fixes #1405)" to keep the cross-references unambiguous.

@zuraffa-review

Copy link
Copy Markdown
Contributor

Walkthrough — review of chore(deps): run on built_collection 6.0.0 via a git override

Nice, tidy change. I verified it end-to-end rather than taking the description on trust:

  • Version + hash: built_collection 6.0.0 is real and current on pub.dev; the lock's sha256 matches pub.dev's archive hash exactly.
  • Override integrity: the git.ref branch head equals the lock's resolved-ref (afeb2eb…), and that branch genuinely widens built_value to built_collection: '>=5.1.1 <7.0.0'.
  • Reproducible: a fresh dart pub get reproduces the committed lock with zero drift.
  • Shipped source clean: dart analyze lib → no issues. (The example/ analyzer noise is pre-existing and codegen-gated — this PR touches no example files.)
  • Consumer safety: pubspec_overrides.yaml is ignored on publish, so downstream resolution is unchanged.

Verdict: No actionable issues. Two 🔵 non-blocking notes inline (mutable branch ref in the override; a wording nit in the override comment). The follow-up to drop the override once built_value ships the widening is well captured in the comments.

@arrrrny
arrrrny merged commit d9360d8 into master Nov 17, 2026
13 checks passed
@arrrrny

arrrrny commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Merge task

merged as d9360d8

Readiness gate (§2): 0 actionable reviewer findings — the two zuraffa-review comments are both 🔵 (non-blocking: the ref-vs-SHA note and the tense nit in the PR body), and the review body itself is 🔵-only. No fixes round was needed.

CI gate (§4U, public repo): every statusCheckRollup check green on head aef63d6 — test, analyze, format, build, prepare, migrator, build_runner_smoke, analyzer_compat (13), analyzer_compat (14), version_sync, CodeRabbit, zuraffa-review (deploy skipped). Mergeable was MERGEABLE / mergeStateStatus: CLEAN, so no conflict resolution and no re-run of the suite was required.

No linked issues (closingIssuesReferences empty, no Closes/Fixes lines in the body).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore maintenance — refactor, bump, migrate, docs, cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant