fix(test): add missing MonitoringProcessEntry fields - #624
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummaryFixes FR-007 snapshot and fixture test compilation failures by populating newly required process fields. Updates Must FixNone. Should FixNone. ConsiderConfirm that the new public Approve / Request ChangesApprove. WalkthroughFR-007 monitoring and CSV tests now populate additional process metadata required by expanded ChangesMonitoring and CSV fixture updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b588c1633
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ppid: None, | ||
| cwd: None, | ||
| env_count: 0, | ||
| state: sharecli_ipc::ProcState::Running, |
There was a problem hiding this comment.
When this test target is compiled, this line does not resolve: sharecli-ipc does not re-export ProcState at the crate root, and the canonical enum in sharecli::runtime::ProcState has Run rather than Running. That means the FR-007 integration test still fails to compile instead of fixing the missing fields, so the required just test gate cannot pass.
AGENTS.md reference: AGENTS.md:L134-L140
Useful? React with 👍 / 👎.
Quality Gate Report❌ Unit Tests: FAILED |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous Review Summaries (6 snapshots, latest commit 989415f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 989415f)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous review (commit 9fa0383)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Resolved IssuesFiles Reviewed (4 files)
Fix these issues in Kilo Cloud Previous review (commit fd324e1)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 files)
Fix these issues in Kilo Cloud Previous review (commit c307770)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 files)
Fix these issues in Kilo Cloud Previous review (commit 53d4fbd)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous review (commit 8b588c1)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 file)
Reviewed by ling-3.0-flash:free · Input: 156.1K · Output: 10.5K · Cached: 475.1K |
Quality Gate Report❌ Unit Tests: FAILED |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| ppid: None, | ||
| cwd: None, | ||
| env_count: 0, | ||
| state: ProcState::default(), |
There was a problem hiding this comment.
CRITICAL: ProcState is not in scope in this test
Line 106 uses ProcState::default(), but no use statement brings ProcState into scope in this file, and sharecli_ipc does not re-export ProcState at the crate root. Add use sharecli::runtime::ProcState; inside the test function or qualify the path as sharecli::runtime::ProcState::default().
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/fr007_ipc_monitoring_report_gate_host_watch.rs`:
- Line 106: Update the ProcState value in the test fixture to use the declared
sharecli_ipc::ProcState::Run variant instead of ProcState::Running, preserving
the rest of the state initialization unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d704dd45-2cf5-4538-a349-c928cd1a6d3d
📒 Files selected for processing (2)
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (15)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Security Scan
- GitHub Check: cargo bench (soft)
- GitHub Check: cargo bench (gate)
- GitHub Check: hyperfine healthz (soft)
- GitHub Check: live pool probe (soft)
- GitHub Check: healthz load burst (soft)
- GitHub Check: dashboard keyboard Tab-cycle
- GitHub Check: dashboard PNG hard diff
- GitHub Check: coverage
- GitHub Check: Offline check after fetch (soft)
- GitHub Check: Unit Tests
- GitHub Check: healthz soak (soft)
- GitHub Check: Kilo Code Review
- GitHub Check: Summary
⚠️ CI failures not shown inline (2)
GitHub Actions: Trunk Check / Lint & Format: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Trunk Check / 0_Lint & Format.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
🧰 Additional context used
📓 Path-based instructions (4)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Use UTF-8 encoding for all text files; do not use Windows-1252 smart quotes or other special characters.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rs
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
Use Rust for the project and validate Rust changes with Cargo build, Cargo test, and Cargo clippy.
**/*.rs: This project uses Rust edition 2021; follow Rust conventions and language-appropriate error handling.
Never useunwraporexpectin production Rust code.
Log all errors with structured logging.
UsePascalCasefor types,snake_casefor functions, methods, and modules, andSCREAMING_SNAKE_CASEfor constants.
Process-pool tests must use appropriate platform gates such as#[cfg(unix)]and#[cfg(windows)]where platform behavior differs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rs
tests/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Maintain acceptance and integration tests for the documented functional requirements, including
tests/fr001_*.rsandtests/integration_cli.rs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
Keep the project compatible with the pinned stable toolchain defined by
rust-toolchain.toml, and ensure code is clean under rustfmt and clippy with warnings denied.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rs
🔇 Additional comments (1)
tests/fr007_ipc_monitoring_report_pool_status.rs (1)
102-110: LGTM!
…napshot (FR-007 Processes expansion round 2)
…-process-resource-metrics)
53d4fbd to
c307770
Compare
Quality Gate Report❌ Unit Tests: FAILED |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/fr007_ps_all_csv.rs`:
- Around line 164-165: Update the ProcessInfo fixture’s disk_read_bytes and
disk_write_bytes fields to use Option<u64> values, replacing the integer
literals with Some(0) or None when the metrics are absent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8fd0bfaa-4a94-4c2c-afda-ef01ea0795e6
📒 Files selected for processing (3)
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ipc_monitoring_report_pool_status.rstests/fr007_ps_all_csv.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (14)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: dashboard keyboard Tab-cycle
- GitHub Check: live pool probe (soft)
- GitHub Check: healthz soak (soft)
- GitHub Check: healthz load burst (soft)
- GitHub Check: coverage
- GitHub Check: hyperfine healthz (soft)
- GitHub Check: cargo bench (soft)
- GitHub Check: dashboard PNG hard diff
- GitHub Check: cargo bench (gate)
- GitHub Check: Unit Tests
- GitHub Check: linux_native (ubuntu-24.04)
- GitHub Check: windows_winfsp (windows-latest)
- GitHub Check: Kilo Code Review
⚠️ CI failures not shown inline (2)
GitHub Actions: Trunk Check / 0_Lint & Format.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Trunk Check / Lint & Format: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
🧰 Additional context used
📓 Path-based instructions (4)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Use UTF-8 encoding for all text files; do not use Windows-1252 smart quotes or other special characters.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ps_all_csv.rstests/fr007_ipc_monitoring_report_pool_status.rs
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
Use Rust for the project and validate Rust changes with Cargo build, Cargo test, and Cargo clippy.
**/*.rs: This project uses Rust edition 2021; follow Rust conventions and language-appropriate error handling.
Never useunwraporexpectin production Rust code.
Log all errors with structured logging.
UsePascalCasefor types,snake_casefor functions, methods, and modules, andSCREAMING_SNAKE_CASEfor constants.
Process-pool tests must use appropriate platform gates such as#[cfg(unix)]and#[cfg(windows)]where platform behavior differs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ps_all_csv.rstests/fr007_ipc_monitoring_report_pool_status.rs
tests/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Maintain acceptance and integration tests for the documented functional requirements, including
tests/fr001_*.rsandtests/integration_cli.rs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ps_all_csv.rstests/fr007_ipc_monitoring_report_pool_status.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
Keep the project compatible with the pinned stable toolchain defined by
rust-toolchain.toml, and ensure code is clean under rustfmt and clippy with warnings denied.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rstests/fr007_ps_all_csv.rstests/fr007_ipc_monitoring_report_pool_status.rs
🔇 Additional comments (3)
tests/fr007_ipc_monitoring_report_gate_host_watch.rs (1)
106-106: Use the declaredProcState::Runvariant.Line 106 still references
sharecli_ipc::ProcState::Running, but the enum definesRun. This is the same unresolved finding from the previous review.tests/fr007_ipc_monitoring_report_pool_status.rs (1)
106-106: BringProcStateinto scope.Line 106 uses
ProcState::default()without an import. Usesharecli::runtime::ProcState::default()or add the correspondinguse. This is the same unresolved finding from the previous review.tests/fr007_ps_all_csv.rs (1)
147-147: LGTM!
| cwd: None, | ||
| env_count: 0, | ||
| state: ProcState::default(), | ||
| disk_read_bytes: 0, |
There was a problem hiding this comment.
CRITICAL: Type mismatch - disk_read_bytes expects Option<u64> but 0 is an integer literal
disk_read_bytes is Option<u64>, and Rust does not implicitly coerce integers to Option<T>. Use None or Some(0) instead.
| disk_read_bytes: 0, | |
| disk_read_bytes: None, |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| env_count: 0, | ||
| state: ProcState::default(), | ||
| disk_read_bytes: 0, | ||
| disk_write_bytes: 0, |
There was a problem hiding this comment.
CRITICAL: Type mismatch - disk_write_bytes expects Option<u64> but 0 is an integer literal
disk_write_bytes is Option<u64>, and Rust does not implicitly coerce integers to Option<T>. Use None or Some(0) instead.
| disk_write_bytes: 0, | |
| disk_write_bytes: None, |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Quality Gate Report❌ Unit Tests: FAILED |
Quality Gate Report❌ Unit Tests: FAILED |
Quality Gate Report❌ Unit Tests: FAILED |
Quality Gate Report❌ Unit Tests: FAILED |
| ppid: None, | ||
| cwd: None, | ||
| env_count: 0, | ||
| state: ProcState::Running, |
There was a problem hiding this comment.
CRITICAL: ProcState::Running does not compile: the enum variant is Run, not Running
Change line 106 to use ProcState::Run to fix the compilation failure.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/fr007_ipc_monitoring_report_gate_host_watch.rs`:
- Line 106: Update the state initialization in the affected test to use the
declared ProcState::Run variant instead of the nonexistent ProcState::Running
variant, preserving the intended running-process state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 30ab48d8-cf1e-49dc-8c9f-8eae98ad4b98
📒 Files selected for processing (1)
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Reproducible build (L52)
- GitHub Check: Summary
⚠️ CI failures not shown inline (20)
GitHub Actions: Trunk Check / Lint & Format: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Trunk Check / 0_Lint & Format.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]GITHUB_TOKEN Permissions
Contents: read
Metadata: read
Packages: read
##[endgroup]
Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
##[error]Unable to resolve action `trunk-io/trunk-action@d90b9166660d5e5afae248a58172a3a0e99d56d5`, unable to find version `d90b9166660d5e5afae248a58172a3a0e99d56d5`
GitHub Actions: Coverage / coverage: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mOUT=$(cargo test --locked --all-features --workspace -- --list)�[0m
�[36;1mCOUNT=$(printf '%s\n' "$OUT" | grep -cE ': test$' || true)�[0m
�[36;1mecho "Discovered tests: $COUNT"�[0m
�[36;1mif [ "${COUNT:-0}" -le 0 ]; then�[0m
�[36;1m echo "No tests discovered (cargo test -- --list). Failing coverage job."�[0m
�[36;1m printf '%s\n' "$OUT" | tail -n 80�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: never
COVERAGE_THRESHOLD: 85
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
##[endgroup]
Updating crates.io index
Updating git repository `https://github.com/KooshaPari/substrate`
Downloading crates ...
Downloaded alloca v0.4.0
Downloaded addr2line v0.25.1
Downloaded mac_address v1.1.8
Downloaded json5 v0.4.1
Downloaded memmem v0.1.1
Downloaded nkeys v0.4.5
Downloaded phf_codegen v0.11.3
Downloaded async-channel v2.5.0
Downloaded lazy_static v1.5.0
Downloaded mintex v0.1.4
Downloaded mime v0.3.17
Downloaded num-conv v0.2.2
Downloaded parking v2.2.1
Downloaded powerfmt v0.2.0
Downloaded lock_api v0.4.14
Downloaded oorandom v11.1.5
Downloaded opentelemetry-http v0.32.0
Downloaded ordered-float v4.6.0
Downloaded percent-encoding v2.3.2
Downloaded phf_shared v0.11.3
Downloaded pin-project-lite v0.2.17
Downloaded pkcs8 v0.10.2
Downloaded anstyle-query v1.1.5
Downloaded deranged v0.5.8
Downloaded kasuari v0.4.12
Downloaded litemap v0.8.2
Downloaded lru v0.18.1
Downloaded pem-rfc7468 v0.7.0
Downloaded anes v0.1.6
Downloaded anyhow v1.0.104
Downloaded arraydeque v0.5.1
Downloaded litrs v1.0.0
Downloaded aho-corasick v1.1.4
Downloaded bit-vec v0.8.0
Downloaded ...
GitHub Actions: Coverage / coverage: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Coverage / 0_coverage.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Visual baseline diff / dashboard PNG hard diff: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1m./target/release/sharecli serve --bind 127.0.0.1:9000 &�[0m
�[36;1mpid=$!�[0m
�[36;1mtrap 'kill $pid 2>/dev/null || true' EXIT�[0m
�[36;1mfor i in $(seq 1 30); do curl -sf -o /dev/null http://127.0.0.1:9000/healthz && break; sleep 1; done�[0m
�[36;1mcurl --fail --silent --show-error http://127.0.0.1:9000/healthz >/dev/null�[0m
�[36;1mnode scripts/a11y/playwright_viewports.mjs�[0m
�[36;1mnode scripts/visual/compare_screenshots.mjs�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
SHARECLI_VISUAL_FIXTURE: 1
##[endgroup]
sharecli serve listening on http://127.0.0.1:9000
ok mobile-375
ok tablet-768
ok desktop-1280
MISS mobile: size 375x812 vs 375x1243
MISS tablet: 2.856% pixels differ (max 0.1%)
MISS desktop: 2.888% pixels differ (max 0.1%)
##[error]Process completed with exit code 1.
GitHub Actions: Visual baseline diff / 0_dashboard PNG hard diff.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1m./target/release/sharecli serve --bind 127.0.0.1:9000 &�[0m
�[36;1mpid=$!�[0m
�[36;1mtrap 'kill $pid 2>/dev/null || true' EXIT�[0m
�[36;1mfor i in $(seq 1 30); do curl -sf -o /dev/null http://127.0.0.1:9000/healthz && break; sleep 1; done�[0m
�[36;1mcurl --fail --silent --show-error http://127.0.0.1:9000/healthz >/dev/null�[0m
�[36;1mnode scripts/a11y/playwright_viewports.mjs�[0m
�[36;1mnode scripts/visual/compare_screenshots.mjs�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
SHARECLI_VISUAL_FIXTURE: 1
##[endgroup]
sharecli serve listening on http://127.0.0.1:9000
ok mobile-375
ok tablet-768
ok desktop-1280
MISS mobile: size 375x812 vs 375x1243
MISS tablet: 2.856% pixels differ (max 0.1%)
MISS desktop: 2.888% pixels differ (max 0.1%)
##[error]Process completed with exit code 1.
GitHub Actions: Bench / hyperfine healthz (soft): fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Bench / cargo bench (gate): fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run cargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate
�[36;1mcargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench pool_list -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench prometheus_render -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench jwt_auth_validate -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
SHARECLI_BENCH_SEED: 42
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
##[endgroup]
�[1m�[92m Updating�[0m crates.io index
�[1m�[92m Updating�[0m git repository `https://github.com/KooshaPari/substrate`
�[1m�[92m Downloading�[0m crates ...
�[1m�[92m Downloaded�[0m clap_complete v4.6.8
�[1m�[92m Downloaded�[0m hashlink v0.12.1
�[1m�[92m Downloaded�[0m jsonwebtoken v11.0.0
�[1m�[92m Downloaded�[0m libsqlite3-sys v0.38.1
�[1m�[92m Downloaded�[0m rusqlite v0.40.1
�[1m�[92m Downloaded�[0m serial_test v4.0.1
�[1m�[92m Downloaded�[0m serial_test_derive v4.0.1
�[1m�[92m Downloaded�[0m zeroize_derive v1.5.0
�[1m�[92m Compiling�[0m futures-sink v0.3.33
�[1m�[92m Compiling�[0m anyhow v1.0.104
�[1m�[92m Compiling�[0m zeroize_derive v1.5.0
�[1m�[92m Compiling�[0m ring v0.17.14
�[1m�[92m Compiling�[0m futures-util v0.3.33
�[1m�[92m Compiling�[0m zeroize v1.9.0
�[1m�[92m Compiling�[0m rustls-pki-types v1.15.1
�[1m�[92m Compiling�[0m aws-lc-rs v1.17.3
�[1m�[92m Compiling�[0m futures-channel v0.3.33
�[1m�[92m...
GitHub Actions: Bench / cargo bench (soft): fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run cargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2
�[36;1mcargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench pool_list -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench prometheus_render -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench jwt_auth_validate -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
SHARECLI_BENCH_SEED: 42
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
##[endgroup]
�[1m�[92m Updating�[0m crates.io index
�[1m�[92m Updating�[0m git repository `https://github.com/KooshaPari/substrate`
�[1m�[92m Downloading�[0m crates ...
�[1m�[92m Downloaded�[0m adler2 v2.0.1
�[1m�[92m Downloaded�[0m aligned-vec v0.6.4
�[1m�[92m Downloaded�[0m alloca v0.4.0
�[1m�[92m Downloaded�[0m async-recursion v1.1.1
�[1m�[92m Downloaded�[0m addr2line v0.25.1
�[1m�[92m Downloaded�[0m anstyle-query v1.1.5
�[1m�[92m Downloaded�[0m atomic-waker v1.1.2
�[1m�[92m Downloaded�[0m approx v0.5.1
�[1m�[92m Downloaded�[0m bit-set v0.5.3
�[1m�[92m Downloaded�[0m anstream v1.0.0
�[1m�[92m Downloaded�[0m anstyle v1.0.14
�[1m�[92m Downloaded�[0m async-broadcast v0.7.2
�[1m�[92m Downloaded�[0m async-trait v0.1.91
�[1m�[92m Downloaded�[0m autocfg v1.5.1
�[1m�[92m Downloaded�[0m bit-set v0.8.0
�[1m�[92m Downloaded�[0m anstyle-parse v1.0.0
�[1m�[92m Downloaded�[0m anyhow v1.0.104
�[1m�[92m Downloaded�[0m atomic v0.6.1
�[1m�[92m Downloaded�[0m base64ct v1.8.3
�[1m�[92m Downloaded�[0m bit-vec v0.6.3
�[1m�[92m Downloaded�[0m bit-vec v0.8.0
�[1...
GitHub Actions: Bench / 0_hyperfine healthz (soft).txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Bench / 1_cargo bench (soft).txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run cargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2
�[36;1mcargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench pool_list -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench prometheus_render -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
�[36;1mcargo bench --locked --bench jwt_auth_validate -- --sample-size 10 --warm-up-time 1 --measurement-time 2�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
SHARECLI_BENCH_SEED: 42
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
##[endgroup]
�[1m�[92m Updating�[0m crates.io index
�[1m�[92m Updating�[0m git repository `https://github.com/KooshaPari/substrate`
�[1m�[92m Downloading�[0m crates ...
�[1m�[92m Downloaded�[0m adler2 v2.0.1
�[1m�[92m Downloaded�[0m aligned-vec v0.6.4
�[1m�[92m Downloaded�[0m alloca v0.4.0
�[1m�[92m Downloaded�[0m async-recursion v1.1.1
�[1m�[92m Downloaded�[0m addr2line v0.25.1
�[1m�[92m Downloaded�[0m anstyle-query v1.1.5
�[1m�[92m Downloaded�[0m atomic-waker v1.1.2
�[1m�[92m Downloaded�[0m approx v0.5.1
�[1m�[92m Downloaded�[0m bit-set v0.5.3
�[1m�[92m Downloaded�[0m anstream v1.0.0
�[1m�[92m Downloaded�[0m anstyle v1.0.14
�[1m�[92m Downloaded�[0m async-broadcast v0.7.2
�[1m�[92m Downloaded�[0m async-trait v0.1.91
�[1m�[92m Downloaded�[0m autocfg v1.5.1
�[1m�[92m Downloaded�[0m bit-set v0.8.0
�[1m�[92m Downloaded�[0m anstyle-parse v1.0.0
�[1m�[92m Downloaded�[0m anyhow v1.0.104
�[1m�[92m Downloaded�[0m atomic v0.6.1
�[1m�[92m Downloaded�[0m base64ct v1.8.3
�[1m�[92m Downloaded�[0m bit-vec v0.6.3
�[1m�[92m Downloaded�[0m bit-vec v0.8.0
�[1...
GitHub Actions: Bench / 2_cargo bench (gate).txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run cargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate
�[36;1mcargo bench --locked --bench config_parse -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench pool_list -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench prometheus_render -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
�[36;1mcargo bench --locked --bench jwt_auth_validate -- --sample-size 10 --warm-up-time 1 --measurement-time 2 --save-baseline ci-gate�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_TERM_COLOR: always
SHARECLI_BENCH_SEED: 42
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
##[endgroup]
�[1m�[92m Updating�[0m crates.io index
�[1m�[92m Updating�[0m git repository `https://github.com/KooshaPari/substrate`
�[1m�[92m Downloading�[0m crates ...
�[1m�[92m Downloaded�[0m clap_complete v4.6.8
�[1m�[92m Downloaded�[0m hashlink v0.12.1
�[1m�[92m Downloaded�[0m jsonwebtoken v11.0.0
�[1m�[92m Downloaded�[0m libsqlite3-sys v0.38.1
�[1m�[92m Downloaded�[0m rusqlite v0.40.1
�[1m�[92m Downloaded�[0m serial_test v4.0.1
�[1m�[92m Downloaded�[0m serial_test_derive v4.0.1
�[1m�[92m Downloaded�[0m zeroize_derive v1.5.0
�[1m�[92m Compiling�[0m futures-sink v0.3.33
�[1m�[92m Compiling�[0m anyhow v1.0.104
�[1m�[92m Compiling�[0m zeroize_derive v1.5.0
�[1m�[92m Compiling�[0m ring v0.17.14
�[1m�[92m Compiling�[0m futures-util v0.3.33
�[1m�[92m Compiling�[0m zeroize v1.9.0
�[1m�[92m Compiling�[0m rustls-pki-types v1.15.1
�[1m�[92m Compiling�[0m aws-lc-rs v1.17.3
�[1m�[92m Compiling�[0m futures-channel v0.3.33
�[1m�[92m...
GitHub Actions: Accessibility / axe dashboard (WCAG 2.x Level A): fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run npm run a11y:dashboard
�[36;1mnpm run a11y:dashboard�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]
> a11y:dashboard
> node scripts/a11y/axe-dashboard.mjs
/home/runner/work/sharecli/sharecli/node_modules/undici/lib/web/cache/cachestorage.js:20
webidl.util.markAsUncloneable(this)
^
TypeError: webidl.util.markAsUncloneable is not a function
at new CacheStorage (/home/runner/work/sharecli/sharecli/node_modules/undici/lib/web/cache/cachestorage.js:20:17)
at Object.<anonymous> (/home/runner/work/sharecli/sharecli/node_modules/undici/index.js:179:25)
at Module._compile (node:internal/modules/cjs/loader:1521:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
at Module.load (node:internal/modules/cjs/loader:1266:32)
at Module._load (node:internal/modules/cjs/loader:1091:12)
at Module.require (node:internal/modules/cjs/loader:1289:19)
at require (node:internal/modules/helpers:182:18)
at Object.<anonymous> (/home/runner/work/sharecli/sharecli/node_modules/jsdom/lib/api.js:12:33)
at Module._compile (node:internal/modules/cjs/loader:1521:14)
Node.js v20.20.2
##[error]Process completed with exit code 1.
GitHub Actions: Accessibility / 1_axe dashboard (WCAG 2.x Level A).txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run npm run a11y:dashboard
�[36;1mnpm run a11y:dashboard�[0m
shell: /usr/bin/bash -e {0}
##[endgroup]
> a11y:dashboard
> node scripts/a11y/axe-dashboard.mjs
/home/runner/work/sharecli/sharecli/node_modules/undici/lib/web/cache/cachestorage.js:20
webidl.util.markAsUncloneable(this)
^
TypeError: webidl.util.markAsUncloneable is not a function
at new CacheStorage (/home/runner/work/sharecli/sharecli/node_modules/undici/lib/web/cache/cachestorage.js:20:17)
at Object.<anonymous> (/home/runner/work/sharecli/sharecli/node_modules/undici/index.js:179:25)
at Module._compile (node:internal/modules/cjs/loader:1521:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
at Module.load (node:internal/modules/cjs/loader:1266:32)
at Module._load (node:internal/modules/cjs/loader:1091:12)
at Module.require (node:internal/modules/cjs/loader:1289:19)
at require (node:internal/modules/helpers:182:18)
at Object.<anonymous> (/home/runner/work/sharecli/sharecli/node_modules/jsdom/lib/api.js:12:33)
at Module._compile (node:internal/modules/cjs/loader:1521:14)
Node.js v20.20.2
##[error]Process completed with exit code 1.
GitHub Actions: Accessibility / 0_dashboard keyboard Tab-cycle.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1m./target/release/sharecli serve --bind 127.0.0.1:9000 &�[0m
�[36;1mpid=$!�[0m
�[36;1mtrap 'kill $pid 2>/dev/null || true' EXIT�[0m
�[36;1mfor i in $(seq 1 30); do curl -sf -o /dev/null http://127.0.0.1:9000/healthz && break; sleep 1; done�[0m
�[36;1mnpm run a11y:keyboard�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
SHARECLI_VISUAL_FIXTURE: 1
##[endgroup]
sharecli serve listening on http://127.0.0.1:9000
> a11y:keyboard
> node scripts/a11y/playwright_keyboard.mjs
node:internal/modules/run_main:123
triggerUncaughtException(
^
browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1234/chrome-headless-shell-linux64/chrome-headless-shell
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
at /home/runner/work/sharecli/sharecli/scripts/a11y/playwright_keyboard.mjs:76:32 {
log: [],
name: 'Error'
}
Node.js v20.20.2
##[error]Process completed with exit code 1.
GitHub Actions: Accessibility / dashboard keyboard Tab-cycle: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1m./target/release/sharecli serve --bind 127.0.0.1:9000 &�[0m
�[36;1mpid=$!�[0m
�[36;1mtrap 'kill $pid 2>/dev/null || true' EXIT�[0m
�[36;1mfor i in $(seq 1 30); do curl -sf -o /dev/null http://127.0.0.1:9000/healthz && break; sleep 1; done�[0m
�[36;1mnpm run a11y:keyboard�[0m
shell: /usr/bin/bash -e {0}
env:
CARGO_HOME: /home/runner/.cargo
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
ZIG_GLOBAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
ZIG_LOCAL_CACHE_DIR: /home/runner/work/sharecli/sharecli/.zig-cache
CACHE_ON_FAILURE: false
SHARECLI_VISUAL_FIXTURE: 1
##[endgroup]
sharecli serve listening on http://127.0.0.1:9000
> a11y:keyboard
> node scripts/a11y/playwright_keyboard.mjs
node:internal/modules/run_main:123
triggerUncaughtException(
^
browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1234/chrome-headless-shell-linux64/chrome-headless-shell
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ npx playwright install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
at /home/runner/work/sharecli/sharecli/scripts/a11y/playwright_keyboard.mjs:76:32 {
log: [],
name: 'Error'
}
Node.js v20.20.2
##[error]Process completed with exit code 1.
GitHub Actions: Quality Gate / Unit Tests: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
GitHub Actions: Quality Gate / Unit Tests: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
test util::toml_lite::tests::group_view ... ok
test util::toml_lite::tests::inline_table ... ok
test util::toml_lite::tests::missing_equals ... ok
test util::toml_lite::tests::root_int ... ok
test util::toml_lite::tests::string_value ... ok
test util::toml_lite::tests::table_section ... ok
test util::topological_sort::tests::cycle_detection_dfs ... ok
test util::topological_sort::tests::cycle_detection_kahn ... ok
test util::topological_sort::tests::dfs_linear_chain ... ok
test util::topological_sort::tests::diamond_graph ... ok
test util::topological_sort::tests::empty_graph ... ok
test util::topological_sort::tests::kahn_and_dfs_agree_on_acyclic ... ok
test util::topological_sort::tests::kahn_linear_chain ... ok
test util::topological_sort::tests::multiple_zero_indegree ... ok
test util::topological_sort::tests::partial_order_respected ... ok
test util::topological_sort::tests::self_loop_is_cycle ... ok
test util::trie_compressed::tests::count ... ok
test util::trie_compressed::tests::empty ... ok
test util::trie_compressed::tests::insert_contains ... ok
test util::trie_compressed::tests::overwrite ... ok
test util::trie_compressed::tests::prefix_not_word ... ok
test util::trie_compressed::tests::shared_prefix ... ok
test util::trim::tests::pad_left_basic ... ok
test util::trim::tests::pad_no_change ... ok
test util::trim::tests::pad_right_basic ... ok
test util::trim::tests::split_lines_basic ... ok
test util::trim::tests::split_words_basic ... ok
test util::trim::tests::trim_end_only ... ok
test util::trim::tests::trim_spaces ... ok
test util::trim::tests::trim_start_only ... ok
test util::typed_id::tests::convert ... ok
test util::typed_id::tests::distinct_types ... ok
test util::typed_id::tests::equality ... ok
test util::typed_id::tests::roundtrip ... ok
test util::url_safe_base64::tests::decode_unchecked_accepts_unpadded ... ok
test util::url_safe_base64::tests::decode_with_and_without_padding ... ok
test util::url_safe...
GitHub Actions: Quality Gate / 5_Unit Tests.txt: fix(test): add missing MonitoringProcessEntry fields
Conclusion: failure
##[group]Run bail() {
�[36;1mbail() {�[0m
�[36;1m printf '::error::install-action: %s\n' "$*"�[0m
🧰 Additional context used
📓 Path-based instructions (4)
**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Use UTF-8 encoding for all text files; do not use Windows-1252 smart quotes or other special characters.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
**/*.rs
📄 CodeRabbit inference engine (CLAUDE.md)
Use Rust for the project and validate Rust changes with Cargo build, Cargo test, and Cargo clippy.
**/*.rs: This project uses Rust edition 2021; follow Rust conventions and language-appropriate error handling.
Never useunwraporexpectin production Rust code.
Log all errors with structured logging.
UsePascalCasefor types,snake_casefor functions, methods, and modules, andSCREAMING_SNAKE_CASEfor constants.
Process-pool tests must use appropriate platform gates such as#[cfg(unix)]and#[cfg(windows)]where platform behavior differs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
tests/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
Maintain acceptance and integration tests for the documented functional requirements, including
tests/fr001_*.rsandtests/integration_cli.rs.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (AGENTS.md)
Keep the project compatible with the pinned stable toolchain defined by
rust-toolchain.toml, and ensure code is clean under rustfmt and clippy with warnings denied.
Files:
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
🪛 GitHub Actions: Coverage / coverage
tests/fr007_ipc_monitoring_report_gate_host_watch.rs
[error] 106-106: Cargo test compilation failed: ProcState has no variant, associated function, or constant named Running at ProcState::Running (E0599). Command: cargo test --locked --all-features --workspace -- --list.
🔇 Additional comments (1)
tests/fr007_ipc_monitoring_report_gate_host_watch.rs (1)
73-73: LGTM!
|
Quality Gate Report❌ Unit Tests: FAILED |
|
Closing as superseded. The MonitoringProcessEntry/ProcessInfo field-extension fixes this branch carried were landed on main via #629 (chore/ci-gate, merged) plus the watcher's own commits. Main now builds green (coverage 81.22%, ci/lint+ci/test required contexts resolve via the new ci-gate workflow). The only remaining diff vs main is a redundant ProcState re-export in handler.rs that main's tests no longer need (they import ProcState from sharecli::runtime directly). |
1 participant
Fix missing fields in
MonitoringProcessEntrytest literals. The struct was extended withcpu_percent,ppid,cwd,env_count,state,disk_read_bytes,disk_write_bytes,fd_count,log_location(FR-007 dashboard expansion), but thefr007_ipc_monitoring_report_gate_host_watchsnapshot test site was not updated, causing Coverage compile failures on the new fields.This patch appends the missing 9 fields (all at 12-space indent to match the inner literal
start_time: 0,) without disturbing the surroundingHostResourceWatchJson { fd_count: 10, … }indent (which is correctly at 8 spaces).