fix(ci): repair main required gates - fr007 test compile fixes + pin rust 1.96.0 - #631
Conversation
…rust 1.96.0 + normalize fmt
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📜 Recent review details⏰ Context from checks skipped due to timeout. (21)
|
| Layer / File(s) | Summary |
|---|---|
FUSE formatting updates crates/sharecli-fuse/... |
Reformats linker directives, version parsing, diagnostics, mount errors, and mount-option assertions without changing behavior. |
IPC formatting updates crates/sharecli-ipc/... |
Reformats command-line error handling and log-buffer expressions without changing behavior. |
Toolchain and test fixture alignment rust-toolchain.toml, tests/... |
Pins the toolchain to 1.96.0 and updates monitoring fixtures to use string state values and thread_count. |
Test assertion formatting tests/c09_l81_stop_force_confirm.rs |
Reformats the existing quit output assertion without changing its condition or failure message. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Possibly related PRs
- KooshaPari/sharecli#623: Introduced functionality in the same FUSE and IPC areas.
- KooshaPari/sharecli#616: Contains related
ProcessInfoandProcStatefixture schema changes. - KooshaPari/sharecli#624: Updates the same FR-007 monitoring snapshot fixtures.
Suggested reviewers: copilot
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | The description explains the changes and test plan but omits required Linked Issues, Implementation Notes, Risk & Rollout, and completed testing evidence. | Add the missing required sections and provide completed test results, risk and rollout details, rollback plan, and linked issue references. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly identifies the CI gate repair, FR-007 test fixes, and Rust 1.96.0 pinning. |
| Docstring Coverage | ✅ Passed | Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/ci-gate-main
✨ Simplify code
- Create PR with simplified code
- Commit simplified code in branch
fix/ci-gate-main
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Quality Gate Report❌ Unit Tests: FAILED |



User description
Summary
Branch protection on
mainrequiresci / lintandci / test(from the #629 ci-gate workflow). Both are currently failing on main:cargo check --workspace --all-targetsfails with 3 compile errors intests/fr007_ipc_monitoring_report_{gate_host_watch,pool_status}.rs:use sharecli::runtime::ProcState;importstate: ProcState::default()but the field isStringon current mainlog_locationfield / missingthread_countfield (canonical struct atcrates/sharecli-ipc/src/handler.rs:179)cargo fmt --checkdrifts becauserust-toolchain.tomlpins floatingstableandrustfmt.tomluses unstable options (group_imports,indent_style) that only nightly honors. The runner's newer stable rustfmt disagrees with the committed formatting.Fix (FR-007 CI gate repair):
ProcStateimport, usestate: "Unknown".into(), replacelog_locationwiththread_count: Nonematching the canonical struct.rust-toolchain.tomlto1.96.0for deterministic rustfmt/rustc in CI.Test plan
ci / lint(cargo fmt --check) passes on this PRci / test(cargo check --workspace --all-targets) passes on this PRCodeAnt-AI Description
Restore deterministic CI checks and fix monitoring report test compatibility
What Changed
Impact
✅ Passing required CI gates✅ Reliable monitoring report validation✅ Consistent builds across CI runs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.