Skip to content

fix(test): add missing MonitoringProcessEntry fields #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 8 commits into from
Closed

fix(test): add missing MonitoringProcessEntry fields #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
66abf0e
fix(test): add missing MonitoringProcessEntry fields (FR-007 dashboar…
Jul 29, 2026
885600b
fix(test): add missing MonitoringProcessEntry fields to pool_status s…
KooshaPari Jul 29, 2026
c307770
fix(test): add missing ProcessInfo fields to ps_all_csv (feat/runtime…
KooshaPari Jul 30, 2026
1eadfcb
fix(test): wrap disk_read_bytes/disk_write_bytes in Some() (Option<u64>)
KooshaPari Jul 30, 2026
fd324e1
fix(test): add ProcState to imports for fr007_ipc_monitoring_report t…
KooshaPari Jul 30, 2026
9fa0383
fix(ipc): re-export ProcState from sharecli_ipc::handler
KooshaPari Jul 30, 2026
989415f
fix(test): use ProcState via handler re-export in gate_host_watch test
KooshaPari Jul 31, 2026
845aeea
fix(test): ProcState::Running -> ProcState::Run (matches src/runtime.…
KooshaPari Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/sharecli-ipc/src/handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use serde_json::Value;
use sharecli::commands::proc::{AgentProcRow, AgentProcSnapshot};
use sharecli::config::Config;
use sharecli::monitoring::HostResourceWatchJson;
use sharecli::runtime::ProcState;
pub use sharecli::runtime::ProcState;
use sharecli::runtime::SharedRuntime;
use sharecli::{ProcessInfo, ProcessPool};
use sharecli_fleet::thermal::ThermalGovernor;
Expand Down
11 changes: 10 additions & 1 deletion tests/fr007_ipc_monitoring_report_gate_host_watch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ fn fr007_ipc_monitoring_report_snapshot_gate_before_host_watch() {
use sharecli::monitoring::HostResourceWatchJson;
use sharecli_fleet::GateStatusSnapshot;
use sharecli_ipc::handler::{
MonitoringProcessEntry, MonitoringReportSnapshot, PoolSnapshot, StatusSnapshot,
MonitoringProcessEntry, MonitoringReportSnapshot, PoolSnapshot, ProcState, StatusSnapshot,
};

let gate = GateStatusSnapshot {
Expand Down Expand Up @@ -99,6 +99,15 @@ fn fr007_ipc_monitoring_report_snapshot_gate_before_host_watch() {
project: Some("demo".into()),
harness: None,
start_time: 0,
cpu_percent: 0.0,
ppid: None,
cwd: None,
env_count: 0,
state: ProcState::Run,
disk_read_bytes: None,
disk_write_bytes: None,
fd_count: None,
log_location: None,
}],
gate: gate.clone(),
host_watch: host_watch.clone(),
Expand Down
11 changes: 10 additions & 1 deletion tests/fr007_ipc_monitoring_report_pool_status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ fn fr007_ipc_monitoring_report_snapshot_pool_status_order() {
use sharecli::monitoring::HostResourceWatchJson;
use sharecli_fleet::GateStatusSnapshot;
use sharecli_ipc::handler::{
MonitoringProcessEntry, MonitoringReportSnapshot, PoolSnapshot, StatusSnapshot,
MonitoringProcessEntry, MonitoringReportSnapshot, PoolSnapshot, ProcState, StatusSnapshot,
};

let gate = GateStatusSnapshot {
Expand Down Expand Up @@ -99,6 +99,15 @@ fn fr007_ipc_monitoring_report_snapshot_pool_status_order() {
project: Some("demo".into()),
harness: None,
start_time: 0,
cpu_percent: 0.0,
ppid: None,
cwd: None,
env_count: 0,
state: ProcState::default(),

@kilo-code-bot kilo-code-bot Bot Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL: ProcState is not in scope in this test

Line 106 uses ProcState::default(), but no use statement brings ProcState into scope in this file, and sharecli_ipc does not re-export ProcState at the crate root. Add use sharecli::runtime::ProcState; inside the test function or qualify the path as sharecli::runtime::ProcState::default().

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

disk_read_bytes: None,
disk_write_bytes: None,
fd_count: None,
log_location: None,
}],
gate: gate.clone(),
host_watch: host_watch.clone(),
Expand Down
9 changes: 8 additions & 1 deletion tests/fr007_ps_all_csv.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ fn fr007_ps_csv_requires_all() {
/// FR-007 / AC-007.83 — unit render_ps_all_csv_body preserves managed + agent sections.
#[test]
fn fr007_ps_all_csv_body_shape() {
use sharecli::runtime::ProcessInfo;
use sharecli::runtime::{ProcessInfo, ProcState};
use sharecli_fleet::HostProcSource;

let proc_source = HostProcSource;
Expand All @@ -156,6 +156,13 @@ fn fr007_ps_all_csv_body_shape() {
harness: Some("claude".into()),
cmd: vec![],
start_time: 0,
cpu_percent: 0.0,
ppid: None,
cwd: None,
env_count: 0,
state: ProcState::default(),
disk_read_bytes: Some(0),
disk_write_bytes: Some(0),
fd_count: None,
thread_count: None,
}];
Expand Down
Loading