docs(promotion): bind current control-plane state - #394
Conversation
|
Warning Review limit reached
Next review available in: 6 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Droid encountered an error —— View job Droid is reviewing code and running a security check… |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25e027dd5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| source_pr = "EffortlessMetrics/shiplog#682" | ||
| source_merge_sha = "2f69daf921d74fb9472584c2a0df31857cfa2384" | ||
| source_target = "175e8c8cee8110c4cf4a42d5534f5dffe45bf426" | ||
| swarm_target = "f99dcbd1ec331c9665b16748b2493bc0a4f0c25f" |
There was a problem hiding this comment.
Extend pending receipts through the bound swarm head
Failure mode: Planning the newly bound f99dcbd head produces an incomplete source-promotion receipt: included_swarm_prs in xtask/src/tasks/promote.rs returns the nonempty pending.swarm_pr_range verbatim instead of inspecting Git, but that range still ends at #381 and therefore omits merged #388, #389, #391, #392, and #393 (as well as the #383/#384 rebinds) that are present before this target. Why here: this line activates decisions for the later head without extending the manifest list, so the generated PR body understates the promoted scope. Fix direction: add every merged PR through f99dcbd to pending.swarm_pr_range and regenerate current-promotion.md. Validation: rerun the exact-head dry-run and confirm its included_swarm_prs matches the Git range. Confidence: high.
AGENTS.md reference: AGENTS.md:L32-L38
Useful? React with 👍 / 👎.
Bind the regenerated current-promotion view to the exact post-#394 swarm target.
Bind the #394 historical current-promotion entry to its exact target tree OID. Required hosted and contributor acceptance checks passed.
What changed
Bind the exact current control-plane state needed to plan promotion of swarm head
f99dcbd1ec331c9665b16748b2493bc0a4f0c25f.This substantive reconciliation updates
plans/shiplog-swarm/promotion-state.tomland regeneratesplans/shiplog-swarm/current-promotion.md.It records exact bounded decisions for:
.github/workflows/release.ymlauthority boundary after fix(release): prove one staged candidate set before publication #391;Scope
Promotion-state evidence and its generated current view only. No source refs, source files, release workflows, tags, releases, packages, or publication state are changed.
Non-goals
This PR does not execute or merge a source promotion, publish a release, or grant permanent swarm authority. All
discard_sourcedecisions are bounded by the next regular-merge source checkpoint.Proof
xtask.exe promotion-state --check— passgit diff --check— passpromote --swarm-sha f99dcbd1ec331c9665b16748b2493bc0a4f0c25f --dry-run— pass; 33 path decisions, source-owned release workflow preserved, prepared overlay2c99d2f2eaa3a19450d2ce89ebdfaabd40ec6b19Shiplog Rust Smallatf99dcbd1ec331c9665b16748b2493bc0a4f0c25f— passA second dry-run attempt was not completed because GitHub GraphQL rate limiting interrupted the read-only evidence walk; it is not reported as a deterministic comparison pass.
Claim boundary
The successful dry-run establishes a read-only, exact-head promotion plan and its per-path decisions. It does not prove source promotion has landed or authorize tags, releases, publication, signing, or package-channel mutation.
Rollback
Revert this PR. No source refs or public release state are changed.
Relates to #246.