Skip to content

fix(promotion): bind historical view evidence - #399

Merged
EffortlessSteven merged 1 commit into
mainfrom
fix/reconcile-historical-promotion-target
Aug 5, 2026
Merged

fix(promotion): bind historical view evidence#399
EffortlessSteven merged 1 commit into
mainfrom
fix/reconcile-historical-promotion-target

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

Bind the #394 transition receipt for plans/shiplog-swarm/current-promotion.md to the tree entry at its recorded historical swarm target 9d38e58....

The exact dry-run after #398 showed that 2904c308... is the current main entry, but the receipt target is the #394 merge target, where the entry is afc811f.... The previous correction accidentally recorded current-head content against a historical target. This PR restores exact target binding without changing the current generated view.

Proof

Scope boundary

Bounded historical promotion evidence only. No source merge, tag, publication, release mutation, overlay edit, or architecture work.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 63d1fde5-c24e-4404-8d00-8728249fa69c

📥 Commits

Reviewing files that changed from the base of the PR and between 409b03e and f1aaa28.

📒 Files selected for processing (1)
  • plans/shiplog-swarm/promotion-state.toml

Summary by CodeRabbit

  • Chores
    • Updated promotion tracking metadata to reflect the latest generated content.

Walkthrough

The promotion manifest updates the swarm_tree_entry object ID for the current-promotion.md transition path.

Changes

Promotion state

Layer / File(s) Summary
Refresh current-promotion tree entry
plans/shiplog-swarm/promotion-state.toml
The recorded swarm_tree_entry OID now matches the regenerated promotion content.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit checked the swarm tree bright,
The promotion path now points right.
One OID changed, the record is clear,
Regenerated content hops near. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and proof, but it omits required Links, Scope, Non-goals, support-tier, policy, and Rollback sections. Add the missing template sections and state the applicable support-tier, policy impact, claim boundary, and safe rollback procedure.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the historical promotion evidence binding change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/reconcile-historical-promotion-target

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@factory-droid

factory-droid Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Droid encountered an error —— View job

Failed to checkout PR #399 branch for review

Droid is reviewing code and running a security check…

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1aaa28360

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

reason = "PR #394 materialized the reconciled promotion ledger and regenerated this current view; this exact binding consumes the post-#394 result without granting permanent swarm authority."
source_tree_entry = { mode = "100644", object_type = "blob", oid = "2cf46f2668123bb939bd5c92beb02f8e375a5664" }
swarm_tree_entry = { mode = "100644", object_type = "blob", oid = "2904c308f8c0e57c01b535a862c5e2a56c86d6f3" }
swarm_tree_entry = { mode = "100644", object_type = "blob", oid = "afc811f082821bc353e0494e49d7c75e41c48ef0" }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bind the active view receipt to the exact head

Failure mode: this records the #394 evidence blob (afc811...), but the active missing_in_swarm/discard_source receipt must also match the current promotion target because verify_current_tree_entries falls back to an exact current-tree comparison for non-special paths; at this commit plans/shiplog-swarm/current-promotion.md is blob 2904c308..., so an exact-head cargo xtask promote --swarm-sha <this head> dry run will reject the active transition with a recorded swarm tree-entry mismatch. Fix direction: rebind the transition swarm_target and tree entry to the actual promotion head/view, or otherwise consume/defer this generated-view receipt instead of leaving stale historical evidence as the active current binding. Validation: cargo xtask promotion-state --check passes, but git ls-tree b15f13c plans/shiplog-swarm/current-promotion.md returns 2904c308... while git ls-tree 9d38e58 plans/shiplog-swarm/current-promotion.md returns afc811.... Confidence: high.

AGENTS.md reference: AGENTS.md:L32-L38

Useful? React with 👍 / 👎.

@EffortlessSteven
EffortlessSteven merged commit 52f7bba into main Aug 5, 2026
26 checks passed
@EffortlessSteven
EffortlessSteven deleted the fix/reconcile-historical-promotion-target branch August 5, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant