fix(promotion): bind historical view evidence - #399
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe promotion manifest updates the ChangesPromotion state
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Droid encountered an error —— View job Droid is reviewing code and running a security check… |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1aaa28360
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| reason = "PR #394 materialized the reconciled promotion ledger and regenerated this current view; this exact binding consumes the post-#394 result without granting permanent swarm authority." | ||
| source_tree_entry = { mode = "100644", object_type = "blob", oid = "2cf46f2668123bb939bd5c92beb02f8e375a5664" } | ||
| swarm_tree_entry = { mode = "100644", object_type = "blob", oid = "2904c308f8c0e57c01b535a862c5e2a56c86d6f3" } | ||
| swarm_tree_entry = { mode = "100644", object_type = "blob", oid = "afc811f082821bc353e0494e49d7c75e41c48ef0" } |
There was a problem hiding this comment.
Bind the active view receipt to the exact head
Failure mode: this records the #394 evidence blob (afc811...), but the active missing_in_swarm/discard_source receipt must also match the current promotion target because verify_current_tree_entries falls back to an exact current-tree comparison for non-special paths; at this commit plans/shiplog-swarm/current-promotion.md is blob 2904c308..., so an exact-head cargo xtask promote --swarm-sha <this head> dry run will reject the active transition with a recorded swarm tree-entry mismatch. Fix direction: rebind the transition swarm_target and tree entry to the actual promotion head/view, or otherwise consume/defer this generated-view receipt instead of leaving stale historical evidence as the active current binding. Validation: cargo xtask promotion-state --check passes, but git ls-tree b15f13c plans/shiplog-swarm/current-promotion.md returns 2904c308... while git ls-tree 9d38e58 plans/shiplog-swarm/current-promotion.md returns afc811.... Confidence: high.
AGENTS.md reference: AGENTS.md:L32-L38
Useful? React with 👍 / 👎.
Summary
Bind the #394 transition receipt for
plans/shiplog-swarm/current-promotion.mdto the tree entry at its recorded historical swarm target9d38e58....The exact dry-run after #398 showed that
2904c308...is the current main entry, but the receipt target is the #394 merge target, where the entry isafc811f.... The previous correction accidentally recorded current-head content against a historical target. This PR restores exact target binding without changing the current generated view.Proof
cargo xtask promotion-state— passcargo xtask promotion-state --check— passgit diff --check— pass2904c308...versus targetafc811f...Scope boundary
Bounded historical promotion evidence only. No source merge, tag, publication, release mutation, overlay edit, or architecture work.