Skip to content

fix(promotion): bind regenerated current view - #395

Merged
EffortlessSteven merged 1 commit into
mainfrom
fix/rebind-current-promotion-view
Aug 4, 2026
Merged

fix(promotion): bind regenerated current view#395
EffortlessSteven merged 1 commit into
mainfrom
fix/rebind-current-promotion-view

Conversation

@EffortlessSteven

Copy link
Copy Markdown
Member

Summary

Why

The exact promotion planner rejected swarm/main because PR #394 regenerated current-promotion.md while the ledger still recorded its pre-#394 tree entry. This is the bounded ledger repair required for the exact current promotion target.

Proof

  • cargo xtask promotion-state --check — pass
  • git diff --check — pass
  • exact planner dry-run against 9d38e58a885d214301bb494315882657e5e506de — pass
  • two exact dry-runs — byte-identical
  • prepared overlay — d230065609cc6f8d738d56017a48c4c37abb4f93
  • path decisions — 41 total; 33 swarm overlay paths
  • routed required check — run 30920560677, Shiplog Rust Small Result success

Claim boundary

This PR makes the promotion ledger truthful for the exact swarm target. It does not merge or publish the source promotion, create a tag, publish crates, or make a GitHub Release public.

@factory-droid

factory-droid Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Droid encountered an error —— View job

Failed to checkout PR #395 branch for review

Droid is reviewing code and running a security check…

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e305d786-aed5-48a4-825b-79b0a6edef1c

📥 Commits

Reviewing files that changed from the base of the PR and between 9d38e58 and 34f686d.

📒 Files selected for processing (1)
  • plans/shiplog-swarm/promotion-state.toml

Summary by CodeRabbit

  • Chores
    • Updated promotion tracking records to remove an obsolete transition.
    • Added the latest promotion result, including its verification details and target information.
    • No user-facing functionality or public interfaces changed.

Walkthrough

The PR updates plans/shiplog-swarm/promotion-state.toml. It removes a stale transition binding tied to PR #381 for current-promotion.md. It adds a new transition record for PR #394, with discard-source disposition, receipt, decision SHA, and tree object IDs.

Changes

Promotion state manifest update

Layer / File(s) Summary
Transition record update
plans/shiplog-swarm/promotion-state.toml
Removes the stale transition binding for PR #381. Adds a new transition record for PR #394 with discard-source disposition, decision SHA, and source/swarm tree object IDs.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Poem

A stale line hops out, a new line hops in,
The manifest ledger records where we've been.
PR #394 now sits on the vine,
Tree objects and SHAs all fall into line.
Thump thump — the promotion state's fine! 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and proof, but it omits several required template sections, including Links, Scope, Non-goals, impact checklists, and Rollback. Add the missing template sections and document scope, non-goals, support-tier and policy impact, links, and safe rollback steps.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the promotion fix and the regenerated current view binding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rebind-current-promotion-view

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EffortlessSteven
EffortlessSteven merged commit 0b9a8f7 into main Aug 4, 2026
24 checks passed
@EffortlessSteven
EffortlessSteven deleted the fix/rebind-current-promotion-view branch August 4, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant