fix(indexing): audit factual contracts and close validation gaps - #4345
Merged
d-v-b merged 12 commits intoSep 14, 2026
Merged
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Correct mathematical API documentation to match supported coordinate, grid, and chunk projection contracts. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Retain the existing unsigned selector fix and update the unsupported mixed-dependency error assertion for general intersection routing. Assisted-by: Codex:GPT-6
…oundaries Assisted-by: Codex:GPT-6
Use lexicographic tuple grouping when chunk indices contain negative values. Cover shared one-axis and two-axis array dependencies, repeated points, and extreme signed coordinates. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
This was referenced Sep 13, 2026
Documentation build overview
24 files changed ·
|
Assisted-by: Codex:GPT-6
Remove implementation history and unsupported historical claims from source and test docstrings. Distinguish immutable coordinate mappings from mutable source values. Assisted-by: Codex:GPT-6
d-v-b
marked this pull request as ready for review
September 14, 2026 09:28
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4345 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 92 92
Lines 12935 12935
=======================================
Hits 12203 12203
Misses 732 732 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-authored PR based on the results of fact-checking factual statements in docstrings and documentation in
zarr-indexing. A lot of alleged falsehoods and inaccuracies were found. I haven't confirmed all of these, but I am reasonably confident that this change makes these descriptions more accurate.🤖 AI text below 🤖
Correct factual claims in zarr-indexing's documentation, source comments, examples, and testing contracts, and fix the correctness defects exposed while checking those claims.
Runtime changes:
intpbefore NumPy can coerce or wrap them.NotImplementedError, consistent with its general classification.(-1, 0)and(0, -1)must remain separate.Expand regression coverage across integer widths, indexing modes, origins, normalization boundaries, map order, negative chunk IDs, repeated points, and one-/two-axis dependencies. Keep main's existing unsigned-selector fix.
The documentation now distinguishes structural box classification from density/order, actual NumPy compatibility from tested examples, metadata inspection from tokenization reads, and parent partition context from direct part resolution. It also corrects TensorStore wire/partition comparisons, cache and benchmark claims, and source integration descriptions. Finite
index_array_boundsremain unenforced during engine loading and are explicitly documented as a limitation.Validation against
ba883a556(also the upstream main revision at submission):Corresponding fork review: d-v-b#333.