test(indexing): broaden planner property coverage - #4346
Merged
d-v-b merged 16 commits intoSep 14, 2026
Merged
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Correct mathematical API documentation to match supported coordinate, grid, and chunk projection contracts. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Retain the existing unsigned selector fix and update the unsupported mixed-dependency error assertion for general intersection routing. Assisted-by: Codex:GPT-6
…oundaries Assisted-by: Codex:GPT-6
Use lexicographic tuple grouping when chunk indices contain negative values. Cover shared one-axis and two-axis array dependencies, repeated points, and extreme signed coordinates. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
github-actions
Bot
added
the
needs release notes
Documentation build overview
24 files changed ·
|
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Remove implementation history and unsupported historical claims from source and test docstrings. Distinguish immutable coordinate mappings from mutable source values. Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
d-v-b
marked this pull request as ready for review
September 14, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This AI-authored PR ensures that
zarr-indexingchunk planner machinery is tested against chunk grids with negative chunk indices.🤖 AI text below 🤖
Depends on #4345. This draft targets upstream
main, so its diff includes the prerequisite audit commits until that PR merges. Follow-up-only diff.The planner's generated dependency-graph tests previously used zero-origin requests and a single nonnegative fixed grid. Expand the pointwise oracle to signed request origins, translated custom grids with signed chunk IDs, arbitrary broadcast ArrayMap dependencies, independent affine axes, ConstantMaps, offsets and strides, duplicate storage points, and empty requests. The oracle enumerates small transforms independently of planner grouping and verifies exact request/storage pairs, each request position exactly once, and the touched chunk set.
Add separate generated checks for shared affine dependencies and mixed affine/array dependencies, which the planner currently rejects explicitly. No production behavior changes.
Validation: 1,523 package tests passed; all applicable prek checks passed. Temporarily removing the negative chunk-ID guard in
_chunk_keysmade the expanded property fail on an out-of-bounds chunk-local coordinate (1 failed, 121 deselected); production code was restored and the 122 planner tests passed again. No new production defects were found.Corresponding fork review: d-v-b#334.
All four final follow-up heads were also combined and verified together: 1,633 package tests/doctests passed, no skips, and the strict documentation build passed.