Skip to content

Fix tight retry-storm in LoungeService reconnect loop #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GhaziTrueAlpha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tight retry-storm in LoungeService reconnect loop #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions youtubeapi/src/main/java/com/liskovsoft/youtubeapi/lounge/LoungeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,18 @@ public void startListening(OnCommand callback) {
e.printStackTrace();
break;
} catch (Exception e) {
// NOTE: without a backoff delay here, a persistent failure (e.g. UnknownHostException
// right after the TV wakes from sleep, before WiFi/DNS is actually back up) turns this
// into a tight busy-loop retrying every few milliseconds, hammering CPU/DNS and never
// giving the network a chance to recover in between attempts. Sleeping between retries
// gives WiFi/DNS time to come back up, same as the normal-path delay above.
Log.e(TAG, e.getMessage());
try {
Thread.sleep(2_000);
} catch (InterruptedException interrupted) {
Log.e(TAG, "Oops. Stopping. Listening thread interrupted.");
break;
}
// Continue to listen whichever is happening.
}
}
Expand Down