Fix tight retry-storm in LoungeService reconnect loop - #29
Open
GhaziTrueAlpha wants to merge 1 commit into
Open
Conversation
The generic catch(Exception) branch in startListening() had no backoff delay, unlike the normal-path Thread.sleep(3000) after a clean disconnect. When startListeningInt() throws a persistent error (e.g. UnknownHostException right after the TV's WiFi wakes from sleep, before DNS is actually reachable again), the loop retried in a tight busy-loop every ~10ms, hammering CPU/DNS instead of giving the network a chance to recover, and preventing the cast session from ever successfully (re)binding. Part of the SmartTube wake-on-cast-while-asleep fix; see WAKE_ON_CAST_FIX.md in the SmartTube repo for the full diagnosis.
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic catch(Exception) branch in startListening() had no backoff delay, unlike the normal-path Thread.sleep(3000) after a clean disconnect. When startListeningInt() throws a persistent error (e.g. UnknownHostException right after the TV's WiFi wakes from sleep, before DNS is actually reachable again), the loop retried in a tight busy-loop every ~10ms, hammering CPU/DNS instead of giving the network a chance to recover, and preventing the cast session from ever successfully (re)binding.
Part of the SmartTube wake-on-cast-while-asleep fix; see WAKE_ON_CAST_FIX.md in the SmartTube repo for the full diagnosis.