Skip to content

BUG: Save ProfilePlot output inside directory paths #5489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kkkakania wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Save ProfilePlot output inside directory paths #5489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions yt/visualization/profile_plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,11 +303,17 @@ def save(
else:
iters = self.plots.items()

if len(self.profiles) == 1: # type: ignore
default_name = str(self.profiles[0].ds) # type: ignore
else:
default_name = "Multi-data"

if name is None:
if len(self.profiles) == 1: # type: ignore
name = str(self.profiles[0].ds) # type: ignore
else:
name = "Multi-data"
name = default_name

name = os.path.expanduser(name)
if os.path.isdir(name) and name != default_name:
name = os.path.join(name, default_name)

name = validate_image_name(name, suffix)
prefix, suffix = os.path.splitext(name)
Expand Down
11 changes: 11 additions & 0 deletions yt/visualization/tests/test_profile_plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ def test_set_units():
p2.set_unit(("gas", "temperature"), "R")


def test_profileplot_save_to_directory(tmp_path):
ds = fake_random_ds(16)
plot = yt.ProfilePlot(
ds.all_data(), ("index", "radius"), ("gas", "density"), weight_field=None
)

expected = tmp_path / f"{ds}_1d-Profile_radius_density.png"
assert plot.save(f"{tmp_path}{os.sep}") == [str(expected)]
assert expected.is_file()


def test_set_labels():
ds = fake_random_ds(16)
ad = ds.all_data()
Expand Down