BUG: Save ProfilePlot output inside directory paths - #5489
Open
Kkkakania wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
ProfilePlot.save()currently validates a directory path as an image name before adding the dataset basename, producing paths such asfolder/.png_1d-Profile_radius_density. This change recognizes existing output directories first, appends the same dataset-based default name used bysave(), and only then validates the image suffix.A regression test saves a real profile plot into a temporary directory and verifies both the returned filename and the created file.
Fixes #5192.
PR Checklist
Verification
.venv/bin/python -m pytest yt/visualization/tests/test_profile_plots.py yt/visualization/tests/test_base_plot_types.py yt/visualization/tests/test_commons.py -q(50 passed).venv/bin/mypy yt/visualization/profile_plotter.pyuvx ruff check yt/visualization/profile_plotter.py yt/visualization/tests/test_profile_plots.pyuvx ruff format --check yt/visualization/profile_plotter.py yt/visualization/tests/test_profile_plots.py