Skip to content

[wpical] Remove absolute path in generated minimath file - #9389

Open
Gold856 wants to merge 1 commit into
wpilibsuite:mainfrom
Gold856:remove-absolute-path-in-minimath
Open

[wpical] Remove absolute path in generated minimath file#9389
Gold856 wants to merge 1 commit into
wpilibsuite:mainfrom
Gold856:remove-absolute-path-in-minimath

Conversation

@Gold856

@Gold856 Gold856 commented Sep 6, 2026

Copy link
Copy Markdown
Member

This fixes issues where running the script at a different location changes the file unnecessarily.

@Gold856
Gold856 requested a review from a team as a code owner September 6, 2026 03:11
@github-actions github-actions Bot added build Monorepo organization, Gradle/CMake/Bazel, upstream_utils, etc component: wpical WPIcal labels Sep 6, 2026
@Gold856
Gold856 force-pushed the remove-absolute-path-in-minimath branch from ea116f8 to f846169 Compare September 6, 2026 03:17
use List::Util qw(min);
use List::MoreUtils qw(pairwise);

say "// THIS IS AUTO-GENERATED BY $0. DO NOT EDIT BY HAND\n";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So… $0 should be the literal argv[0]. We could run this script by relative path rather than by the absolute path we currently use, which should avoid the problem without requiring a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Monorepo organization, Gradle/CMake/Bazel, upstream_utils, etc component: wpical WPIcal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants