Skip to content

[javac] Check yields in do-while loops - #9388

Open
nano-maxwell wants to merge 2 commits into
wpilibsuite:mainfrom
nano-maxwell:feature/do-while-yield-check
Open

[javac] Check yields in do-while loops#9388
nano-maxwell wants to merge 2 commits into
wpilibsuite:mainfrom
nano-maxwell:feature/do-while-yield-check

Conversation

@nano-maxwell

Copy link
Copy Markdown
Contributor
  • Add do-while loop checks to CoroutineYieldInLoopDetector
  • Add a method to use the same loop-tracking logic for both while and do-while loops
  • Add coverage for do-while loops in lambdas, methods, and nested loop cases

Fixes #9343.

@nano-maxwell
nano-maxwell requested a review from a team as a code owner September 6, 2026 01:40
@github-actions github-actions Bot added type: testing Related to testing. component: javac plugin Java compiler plugin labels Sep 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97e0f204ec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@nano-maxwell
nano-maxwell force-pushed the feature/do-while-yield-check branch from 97e0f20 to 6f4c7bb Compare September 6, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: javac plugin Java compiler plugin type: testing Related to testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Perform compile-time check for do-while loop without a yield

1 participant