Skip to content

[commands] Lower SysId default step voltage - #9375

Open
TLNing260310 wants to merge 1 commit into
wpilibsuite:mainfrom
TLNing260310:fix-7794-lower-sysid-step-voltage
Open

[commands] Lower SysId default step voltage#9375
TLNing260310 wants to merge 1 commit into
wpilibsuite:mainfrom
TLNing260310:fix-7794-lower-sysid-step-voltage

Conversation

@TLNing260310

Copy link
Copy Markdown

Summary

  • lower the default SysId dynamic step voltage from 7 V to 4 V in Java, C++, and Python
  • make the Java, C++, and Python SysIdRoutine examples configure the step voltage explicitly and tell users to adjust it for their mechanism
  • update the existing dynamic-voltage regression tests for the new default

Validation

  • wpiformat 2026.71 (including C++ lint)
  • Black formatting check for the changed Python files
  • Python syntax compilation
  • stale 7 V reference scan across the implementations, tests, and SysId examples

The focused compiled tests could not be started locally because this Windows environment has no JDK, and the repository-pinned Bazel binary download timed out. GitHub Actions will run the project build and test matrix.

Closes #7794

@TLNing260310
TLNing260310 requested review from a team as code owners September 1, 2026 05:21
@github-actions github-actions Bot added component: command-based WPILib Command Based Library type: testing Related to testing. component: examples robotpy Issues that affect RobotPy (Python) support labels Sep 1, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T05:23:53.678176Z 7836dd2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TLNing260310

Copy link
Copy Markdown
Author

Documentation companion: wpilibsuite/wpilib-docs#3356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: command-based WPILib Command Based Library component: examples robotpy Issues that affect RobotPy (Python) support type: testing Related to testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make SysId's default step voltage smaller

1 participant