[ci] Use Blacksmith runners - #9357
Conversation
github-actions
Bot
added
the
build
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ab0e1889e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
0b60ea6 to
5a547bd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a547bdc6c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
5a547bd to
0a97b77
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a97b77212
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ce543d9 to
4f018fa
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f018fafd4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
4f018fa to
478ff88
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 478ff8890f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
478ff88 to
e3af13c
Compare
| jobs: | ||
| wpilib-mvn-development_unused_cleanup: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ${{ case(github.repository_owner == 'wpilibsuite', 'blacksmith-2vcpu-ubuntu-2404', 'ubuntu-24.04') }} |
There was a problem hiding this comment.
It probably makes more sense for this small automation stuff to use ubuntu-slim?
There was a problem hiding this comment.
ubuntu-slim runners aren’t enough for cache cleanup. Some of those runs exceed 15 minutes.
There was a problem hiding this comment.
Hm, from a quick look through, it seems like all the maven cleanups finish under 15 minutes? But yeah the general cache cleanup does look like it can take a while.
There was a problem hiding this comment.
Otherwise though, I don't think we necessarily need to move all the things to Blacksmith runners. Definitely we should move all our build/test jobs for speed, but for example we can leave the pregen job be for now to unblock our speedy builds.
There was a problem hiding this comment.
Well, the other thing I wanted Blacksmith for was CI log search. It's leagues better than GitHub's. In the event any of the small jobs start failing weirdly, I'd like to be able to go through logs to investigate and also have better metrics into when and how many are failing.
(also these being 2 vCPU runners means we're allocated less cores than we would have on GitHub, which is nice from a general resource usage/environmental perspective.)
There was a problem hiding this comment.
Hmm. Does Blacksmith offer 1 vCPU runners like ubuntu-slim?
There was a problem hiding this comment.
No, only 2 vCPU runners and above.
e3af13c to
59bf6c8
Compare
2 participants
No description provided.