[bazel][robotpy] Generate Python type stubs - #9356
Draft
virtuald wants to merge 1 commit into
Draft
Conversation
auscompgeek
reviewed
Aug 27, 2026
|
|
||
| def robotpy_host_only_select(values): | ||
| return select({ | ||
| "//shared/bazel/rules/robotpy:host_platform": values, |
Member
There was a problem hiding this comment.
Wouldn't this be equivalent, and much simpler?
Suggested change
| "//shared/bazel/rules/robotpy:host_platform": values, | |
| "@platforms//host": values, |
| }) | ||
|
|
||
| def robotpy_host_compatibility(): | ||
| return HOST_CONSTRAINTS + robotpy_compatibility_select() |
Member
There was a problem hiding this comment.
Hmm. I suspect we actually want this stuff to be effective when exec == target, rather than host == target. When host != exec this would still break.
Member
Author
|
I told the 🤖 to only build artifacts once, and this is the design it proposed to implement. I don't have any idea if it actually did this: Recommended design
|
Member
Author
|
TODO: also add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.