Skip to content

[WOOMOB-3814] Restore default padding on JITM banner CTA button #16407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
malinajirka wants to merge 2 commits into
base: trunk
Choose a base branch
from
+3 −2
Open

[WOOMOB-3814] Restore default padding on JITM banner CTA button #16407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ff1f93
Restore default padding on JITM banner CTA button
malinajirka Aug 11, 2026
73f0918
Add release note for the JITM banner CTA padding fix
malinajirka Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- [*] Bundles containing a subscription product can no longer be added to an order [https://github.com/woocommerce/woocommerce-android/pull/16381]
- [*****] [Internal] Update Compose BOM from 2025.11.01 to 2026.06.01, which moves Compose from 1.9.5 to 1.11.4 [https://github.com/woocommerce/woocommerce-android/pull/16357]
- [*] [Internal] Remove SiteModel#mXmlRpcUrl [https://github.com/woocommerce/woocommerce-android/pull/16301]
- [*] Fixed the JITM banner's button showing no padding around its pressed/highlighted state [https://github.com/woocommerce/woocommerce-android/pull/16407]

25.4
-----
Expand Down
4 changes: 2 additions & 2 deletions WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/banner/Banner.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ package com.woocommerce.android.ui.payments.banner
import android.content.res.Configuration
import androidx.compose.foundation.Image
import androidx.compose.foundation.isSystemInDarkTheme
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.material3.ButtonDefaults
import androidx.compose.material3.Card
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
Expand Down Expand Up @@ -108,7 +108,7 @@ fun Banner(bannerState: JitmState.Banner) {

TextButton(
onClick = bannerState.onPrimaryActionClicked,
contentPadding = PaddingValues(start = dimensionResource(id = R.dimen.minor_00)),
contentPadding = ButtonDefaults.TextButtonContentPadding,
modifier = Modifier.constrainAs(ctaButton) {
top.linkTo(description.bottom)
start.linkTo(parent.start, margin = majorMargin)
Expand Down
Loading