[WOOMOB-3814] Restore default padding on JITM banner CTA button - #16407
Open
malinajirka wants to merge 2 commits into
Open
[WOOMOB-3814] Restore default padding on JITM banner CTA button#16407malinajirka wants to merge 2 commits into
malinajirka wants to merge 2 commits into
Conversation
Collaborator
|
|
malinajirka
marked this pull request as ready for review
August 11, 2026 14:25
The custom contentPadding zeroed out all sides (not just start), leaving the pressed/ripple background flush with the button text.
There was a problem hiding this comment.
AI Code Review - No issues found. The changes look good.
This PR swaps a manual zero-start PaddingValues for the standard ButtonDefaults.TextButtonContentPadding on the JITM banner CTA TextButton, restoring Material3 default padding. The unused PaddingValues import is correctly removed and ButtonDefaults is imported. No correctness, security, or backwards-compatibility concerns.
PR housekeeping
- UI-only change: the restored default padding is visible on the JITM banner CTA button; no test plan required.
Automatic review · claude-opus-4-8 · Workflow run
How to reply to a finding
Reply on this review (or inline at the line the finding refers to) with one of:
@claude addressed- I made the change. Bot verifies against the next diff before marking resolved.@claude rejected: <reason>- Will not fix; reason gets quoted on the next review.@claude not-applicable- Finding does not apply (wrong file, already covered elsewhere, etc.).
The bot honours these on the next review pass.
malinajirka
force-pushed
the
issue/WOOMOB-3814-jitm-cta-padding
branch
from
August 11, 2026 14:28
225d984 to
73f0918
Compare
kidinov
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes WOOMOB-3814
The JITM banner's CTA button used a custom
contentPaddingthat only setstart, but Compose'sPaddingValuesconstructor defaults every unspecified side to0.dp— so it silently zeroed out top/end/bottom too. That collapsed the button's pressed/rippleSurfacedown to the exact size of the text, so the highlight had no padding on any side. RestoringButtonDefaults.TextButtonContentPaddinggives the ripple normal insets again.Test Steps
developer.properties, setwc.jitm_testing_json_file_name=jitm_testing.json, then rebuild/install.Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.