-
Notifications
You must be signed in to change notification settings - Fork 145
Test translation context suggestions for Android strings #16302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
iangmaia
wants to merge
5
commits into
trunk
Choose a base branch
from
test/translation-context-plugin-v2
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
588ef7a
Test translation context for Android strings
iangmaia 02eb57f
Load translation context plugin in CI
iangmaia 1f5290b
Include Android fixture in context search
iangmaia bb020c3
Update i18n context generator to 0.5.1
iangmaia 78d386d
Use inline-only translation context feedback
iangmaia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...mmerce/src/main/kotlin/com/woocommerce/android/ui/test/TranslationContextPluginFixture.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package com.woocommerce.android.ui.test | ||
|
|
||
| import android.content.Context | ||
| import com.woocommerce.android.R | ||
|
|
||
| /** | ||
| * Test-only resource usages for exercising translation-context suggestions. | ||
| */ | ||
| internal object TranslationContextPluginTest { | ||
| fun orderEditorLabels(context: Context): List<String> = listOf( | ||
| context.getString(R.string.translation_context_test_order_save_button), | ||
| context.getString(R.string.translation_context_test_order_processing_status), | ||
| context.getString(R.string.translation_context_test_order_note_hint) | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -4777,4 +4777,7 @@ | |||||||
| <string name="ai_assistant_confirmation_product_variation_update_title_with_name" a8c-src-lib="module:ai-assistant-feature">Update variation %1$s (#%2$s) for product #%3$s</string> | ||||||||
| <string name="error_site_url_certificate_validity" a8c-src-lib="module:login">We couldn\'t establish a secure connection. Check that your device date and time are correct, then try again.</string> | ||||||||
| <string name="error_site_url_remote_certificate" a8c-src-lib="module:login">We couldn\'t verify this site\'s security certificate. Contact your hosting provider or site administrator, then try again.</string> | ||||||||
| <string name="translation_context_test_order_save_button">Save</string> | ||||||||
| <string name="translation_context_test_order_processing_status">Processing</string> | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Generated by 🚫 Danger |
||||||||
| <string name="translation_context_test_order_note_hint">Add a note</string> | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Generated by 🚫 Danger |
||||||||
| </resources> | ||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated by 🚫 Danger