Test translation context suggestions for Android strings - #16302
Draft
iangmaia wants to merge 5 commits into
Draft
Test translation context suggestions for Android strings#16302iangmaia wants to merge 5 commits into
iangmaia wants to merge 5 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
iangmaia
added
type: task
iangmaia
added
category: tooling
Collaborator
|
|
| <string name="error_site_url_certificate_validity" a8c-src-lib="module:login">We couldn\'t establish a secure connection. Check that your device date and time are correct, then try again.</string> | ||
| <string name="error_site_url_remote_certificate" a8c-src-lib="module:login">We couldn\'t verify this site\'s security certificate. Contact your hosting provider or site administrator, then try again.</string> | ||
| <string name="translation_context_test_order_save_button">Save</string> | ||
| <string name="translation_context_test_order_processing_status">Processing</string> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <string name="translation_context_test_order_processing_status">Processing</string> | |
| <!-- A status label displayed in the order editor screen indicating that an order is currently being processed. --> | |
| <string name="translation_context_test_order_processing_status">Processing</string> |
Generated by 🚫 Danger
| <string name="error_site_url_remote_certificate" a8c-src-lib="module:login">We couldn\'t verify this site\'s security certificate. Contact your hosting provider or site administrator, then try again.</string> | ||
| <string name="translation_context_test_order_save_button">Save</string> | ||
| <string name="translation_context_test_order_processing_status">Processing</string> | ||
| <string name="translation_context_test_order_note_hint">Add a note</string> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <string name="translation_context_test_order_note_hint">Add a note</string> | |
| <!-- Placeholder hint text shown inside a text input field in an order editor screen, prompting the user to type an internal note for the order. --> | |
| <string name="translation_context_test_order_note_hint">Add a note</string> |
Generated by 🚫 Danger
| <string name="ai_assistant_confirmation_product_variation_update_title_with_name" a8c-src-lib="module:ai-assistant-feature">Update variation %1$s (#%2$s) for product #%3$s</string> | ||
| <string name="error_site_url_certificate_validity" a8c-src-lib="module:login">We couldn\'t establish a secure connection. Check that your device date and time are correct, then try again.</string> | ||
| <string name="error_site_url_remote_certificate" a8c-src-lib="module:login">We couldn\'t verify this site\'s security certificate. Contact your hosting provider or site administrator, then try again.</string> | ||
| <string name="translation_context_test_order_save_button">Save</string> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <string name="translation_context_test_order_save_button">Save</string> | |
| <!-- A button label in an order editor screen that saves the current order when tapped. --> | |
| <string name="translation_context_test_order_save_button">Save</string> |
Generated by 🚫 Danger
Collaborator
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a do-not-merge integration test for the
translation_context_checkerfrom Automattic/dangermattic#112. It pins that branch, adds three deliberately under-describedstrings.xmlresources with Kotlin usages, and requests inline translation suggestions.The fixtures represent the Save button in an order editor, the status shown while that order is processing, and the hint for adding an internal order note. This description is intentionally self-contained because pull request title and description context is enabled by default.
Test Steps
i18n-context-generator0.5.1 and loads the complete plugin from the Dangermattic branch.Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.