Repository navigation
Cookies: add tests for expiry at read, path length order, repeated attributes and other methods - #64550
Open
rifmj wants to merge 1 commit into
Open
Cookies: add tests for expiry at read, path length order, repeated attributes and other methods#64550rifmj wants to merge 1 commit into
rifmj wants to merge 1 commit into
Conversation
…tributes and other methods Drafted with AI help.
This was referenced Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New tests in
cookies/. I found no existing coverage for these cases:samesite/methods-beyond-get-post.html: PUT, DELETE, PATCH and OPTIONS carry aSameSite=Strictcookie on a same-origin request.ordering/equal-segment-count.html: two paths with the same number of segments sort by length, not by creation time.ordering.sub.htmlcovers paths with different segment counts only.attributes/expired-at-read.html: an expired cookie is gone with noSet-Cookiein between, checked separately for theCookieheader anddocument.cookie, with a control cookie. Each check waits 4 seconds, so the file hastimeout=long.attributes/last-attribute.html:Max-AgebeforeExpiresin both directions, a lastPathwithout a leading/, and an emptyDomain.attributes/last-attribute.tentative.html: a last unparsableExpiresandDomain=.. Browsers differ here from RFC 6265bis 5.6.1 step 2 and 5.6.3, so these two are tentative.Results under
./wpt servewith Playwright 1.64.1 builds, three identical runs. I did not run./wpt run.methods-beyond-get-postequal-segment-countexpired-at-readlast-attributelast-attribute.tentativeThe WebKit failure is the
Path=foocase: the cookie API reports the literal pathfoo, and the cookie does not come back on the default path. I have not checked Safari.Related: whatwg/fetch#1965, whatwg/fetch#1826, httpwg/http-extensions#3581, httpwg/http-extensions#3582, httpwg/http-extensions#3583.
Drafted with AI help.