Repository navigation
Conversation
Drafted with AI help.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small corrections to the Expires and Max-Age steps of
draft-ietf-httpbis-layered-cookies.maxAgeSeenis created inside the loop, so it is false again for every attribute.Max-Age=3600; Expires=<past>is then rejected, andMax-Age=0; Expires=<future>is kept. RFC6265bis: Attributes should specify how missing/invalid values should be handled #2046 says Max-Age and Expires are meant to interact, and all browsers I tried give Max-Age priority (Chromium 156, Firefox 157, WebKit 27.2). The fix moves the variable above the loop.expiryTime.There is no change of intent. How a later invalid Expires should behave is a separate question, in #3581.
WPT:
cookies/attributes/last-attribute.htmlin web-platform-tests/wpt#64550 covers item 1.Drafted with AI help.