Skip to content

Editorial: Improve clarity of EnsureCSPDoesNotBlockStringCompilation #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antosart merged 1 commit into from
Jul 29, 2026
Merged

Editorial: Improve clarity of EnsureCSPDoesNotBlockStringCompilation #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1497,11 +1497,9 @@ spec:SRI; urlPrefix: https://w3c.github.io/webappsec-subresource-integrity
returns normally if string compilation is allowed, and throws an "`EvalError`"
if not:

1. If |compilationType| is "`TIMER`", then:
1. Let |sourceString| be |codeString|.

1. Let |sourceString| be |codeString|.

1. Else:
1. If |compilationType| is not "`TIMER`", then:

1. Let |compilationSink| be "Function" if |compilationType| is "`FUNCTION`", and "eval" otherwise.

Expand All @@ -1524,16 +1522,14 @@ spec:SRI; urlPrefix: https://w3c.github.io/webappsec-subresource-integrity

1. Otherwise, set |isTrusted| to `false`.

1. Let |sourceToValidate| be a [=new=] {{TrustedScript}} object created in |realm|
whose [=TrustedScript/data=] is set to |codeString| if |isTrusted| is `true`, and
|codeString| otherwise.
1. If |isTrusted| is `false`, then:

1. Let |sourceString| be the result of executing the [=get trusted type compliant string=] algorithm, with
{{TrustedScript}}, |realm|, |sourceToValidate|, |compilationSink|, and `'script'`.
1. Set |sourceString| to the result of executing the [=get trusted type compliant string=] algorithm, with
{{TrustedScript}}, |realm|, |codeString|, |compilationSink|, and `'script'`.

1. If the algorithm throws an error, throw an {{EvalError}}.
1. If the algorithm throws an error, throw an {{EvalError}}.

1. If |sourceString| is not equal to |codeString|, throw an {{EvalError}}.
1. If |sourceString| is not equal to |codeString|, throw an {{EvalError}}.

1. Let |result| be "`Allowed`".

Expand Down
Loading