Skip to content

Editorial: Improve clarity of EnsureCSPDoesNotBlockStringCompilation - #817

Merged
antosart merged 1 commit into
w3c:mainfrom
lukewarlow:EnsureCSPDoesNotBlockStringCompilation-fix
Jul 29, 2026
Merged

Editorial: Improve clarity of EnsureCSPDoesNotBlockStringCompilation#817
antosart merged 1 commit into
w3c:mainfrom
lukewarlow:EnsureCSPDoesNotBlockStringCompilation-fix

Conversation

@lukewarlow

@lukewarlow lukewarlow commented Jul 28, 2026 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Member

I noticed a weird line in the algorithm, so I decided to clean it up a bit to make it more easily understandable. This is editorial and doesn't impact behaviour.

The weird line:

Let sourceToValidate be a new TrustedScript object created in realm whose data is set to codeString if isTrusted is true, and codeString otherwise.

Preview | Diff

@lukewarlow
lukewarlow force-pushed the EnsureCSPDoesNotBlockStringCompilation-fix branch from 7706a9c to f95bf7f Compare July 28, 2026 17:30
fred-wang
fred-wang approved these changes Jul 28, 2026
View reviewed changes

@fred-wang fred-wang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antosart
antosart approved these changes Jul 29, 2026
View reviewed changes

@antosart antosart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This does sound much cleaner.

@antosart
antosart merged commit 43b9e49 into w3c:main Jul 29, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Jul 29, 2026
@lukewarlow @github-actions
Editorial: Improve clarity of EnsureCSPDoesNotBlockStringCompilation (#…
2f509ec 
…817)

SHA: 43b9e49
Reason: push, by antosart

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@lukewarlow
lukewarlow deleted the EnsureCSPDoesNotBlockStringCompilation-fix branch July 29, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antosart antosart antosart approved these changes
+1 more reviewer
@fred-wang fred-wang fred-wang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukewarlow @fred-wang @antosart