-
Notifications
You must be signed in to change notification settings - Fork 84
fix(api): separate hreflang slugs from locale-switch navigation #3462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hellofanny
wants to merge
11
commits into
dev
Choose a base branch
from
fix/api-hreflang-default-locale-slug
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+756
−75
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d7c95e1
fix(api): resolve hreflang slugs from availableLinkIds only
hellofanny e11d155
fix(api): keep hreflang alternates reciprocal for untranslated products
hellofanny 4edbce3
Merge branch 'dev' into fix/api-hreflang-default-locale-slug
hellofanny c23330b
fix(api): log Catalog Dataplane failures in getLocalizedProductEntry
hellofanny 10206cb
fix(api): add defaultLocaleSlug for locale-switch navigation
hellofanny 197b099
docs(api): correct linkText locale claim in assertSkuMatchesSlug
hellofanny 5d85a9a
test(core): cover the locale selector slug fallback chain
hellofanny e43efc5
test(core): cover the locale selector redirect and product context
hellofanny 5896673
test(core): cover the locale button wiring to the product context
hellofanny 4ad475b
test(core): drop redundant locale selector cases
hellofanny 445311e
Merge branch 'dev' into fix/api-hreflang-default-locale-slug
lemagnetic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.