-
Notifications
You must be signed in to change notification settings - Fork 91
refactor(packages)!: extension renaming #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export * from './media'; | ||
| export * from './google-cast'; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| import { GoogleCastElement } from '../../extensions/google-cast'; | ||
| import { GoogleCastExtension } from '../../extensions/google-cast'; | ||
| import { safeDefine } from '../../registration/safe-define'; | ||
|
|
||
| export { GoogleCastElement }; | ||
| export { GoogleCastExtension }; | ||
|
|
||
| safeDefine(GoogleCastElement); | ||
| safeDefine(GoogleCastExtension); | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| [GoogleCastElement.tagName]: GoogleCastElement; | ||
| [GoogleCastExtension.tagName]: GoogleCastExtension; | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,12 @@ | ||
| import { MuxDataElement } from '../../extensions/mux-data'; | ||
| import { MuxDataExtension } from '../../extensions/mux-data'; | ||
| import { safeDefine } from '../../registration/safe-define'; | ||
|
|
||
| export { MuxDataElement }; | ||
| export { MuxDataExtension }; | ||
|
|
||
| safeDefine(MuxDataElement); | ||
| safeDefine(MuxDataExtension); | ||
|
|
||
| declare global { | ||
| interface HTMLElementTagNameMap { | ||
| [MuxDataElement.tagName]: MuxDataElement; | ||
| [MuxDataExtension.tagName]: MuxDataExtension; | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export * from './google-cast-element'; | ||
| export * from './extension'; |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the file name
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed in 0e19841 to |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export * from './mux-data-element'; | ||
| export * from './extension'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the file name
google-cast-extension.tsshould be justextension.tsto follow the adapter pattern.the folder name already indicates what extension it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed in 0e19841 to
extension.ts; the folder names the extension. Nothing in the reference builder or workspace tooling keyed on the old file names, only the barrels and tests, which follow the file.