refactor(packages)!: extension renaming - #2600
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@videojs/cdn
@videojs/cloudflare-video
@videojs/core
@videojs/dash-video
@videojs/element
@videojs/google-cast
@videojs/hlsjs-video
@videojs/html
@videojs/media
@videojs/mux-audio
@videojs/mux-data
@videojs/mux-video
@videojs/native-hls-video
@videojs/react
@videojs/shaka-video
@videojs/spf
@videojs/spotify-audio
@videojs/store
@videojs/tiktok-video
@videojs/twitch-video
@videojs/utils
@videojs/vimeo-video
@videojs/wistia-video
@videojs/youtube-video
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 2 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — 1 small size change
📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — 1 small size change
📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (7)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 2, 2026 23:32
2667e76 to
f917ebe
Compare
mihar-22
marked this pull request as draft
September 3, 2026 00:04
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 03:19
f917ebe to
6a9e429
Compare
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 04:13
6a9e429 to
53851eb
Compare
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 05:03
53851eb to
78662f7
Compare
mihar-22
marked this pull request as ready for review
September 3, 2026 05:31
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 05:52
78662f7 to
a13db4b
Compare
mihar-22
changed the title
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 06:57
a13db4b to
1cbad30
Compare
luwes
requested changes
Sep 3, 2026
Collaborator
There was a problem hiding this comment.
the file name google-cast-extension.ts should be just extension.ts to follow the adapter pattern.
the folder name already indicates what extension it is
Member
Author
There was a problem hiding this comment.
Renamed in 0e19841 to extension.ts; the folder names the extension. Nothing in the reference builder or workspace tooling keyed on the old file names, only the barrels and tests, which follow the file.
Collaborator
There was a problem hiding this comment.
the file name mux-data-extension.ts should be just extension.ts to follow the adapter pattern.
the folder name already indicates what extension it is
Member
Author
There was a problem hiding this comment.
Renamed in 0e19841 to extension.ts; the folder names the extension. Nothing in the reference builder or workspace tooling keyed on the old file names, only the barrels and tests, which follow the file.
Collaborator
There was a problem hiding this comment.
should this follow the same pattern then? make the file name extension.tsx
Member
Author
There was a problem hiding this comment.
Yes, renamed in 0e19841 to extension.tsx to match html.
Collaborator
There was a problem hiding this comment.
should this follow the same pattern then? make the file name extension.tsx
Member
Author
There was a problem hiding this comment.
Yes, renamed in 0e19841 to extension.tsx to match html.
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 19:59
1cbad30 to
0e19841
Compare
luwes
approved these changes
Sep 3, 2026
Contributor
|
E2E triage: inconclusive — #2621. The registry consumer cannot resolve the optional |
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 20:41
0e19841 to
332c824
Compare
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 20:56
332c824 to
4f07d14
Compare
The framework-neutral extension classes and their props/defaults gain the `Extension` suffix so the kind is visible at the import site: - `@videojs/mux-data`: `MuxData` -> `MuxDataExtension`, `MuxDataProps` -> `MuxDataExtensionProps`, `muxDataDefaultProps` -> `muxDataExtensionDefaultProps` - `@videojs/google-cast`: `GoogleCast` -> `GoogleCastExtension`, and the same for its props and defaults The html elements follow the same scheme (`MuxDataElement` -> `MuxDataExtension`, `GoogleCastElement` -> `GoogleCastExtension`); their tags and the React façade names (`MuxData`, `GoogleCast`) are unchanged. BREAKING CHANGE: the exports listed above are renamed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mihar-22
force-pushed
the
pr3/extension-naming
branch
from
September 3, 2026 21:02
4f07d14 to
d7b1402
Compare
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Names the framework-neutral extension classes with an
Extensionsuffix and moves their defaults onto the class.@videojs/mux-dataMuxData,MuxDataProps,muxDataDefaultPropsMuxDataExtension,MuxDataExtensionProps,MuxDataExtension.defaultProps@videojs/google-castGoogleCast,GoogleCastProps,googleCastDefaultPropsGoogleCastExtension,GoogleCastExtensionProps,GoogleCastExtension.defaultProps@videojs/htmlMuxDataElement,GoogleCastElementMuxDataExtension,GoogleCastExtension(tags unchanged)@videojs/reactMuxData,GoogleCastThe html element files import the base class under a
*Basealias since both classes share a name, as the React façades already did.Validation
Build, typecheck, lint, workspace check;
@videojs/mux-data,@videojs/google-cast,@videojs/html,@videojs/react, and site tests.🤖 Generated with Claude Code
Note
Low Risk
Mechanical rename and default-props relocation with no runtime behavior changes; breaking only for imports of removed symbols from
@videojs/mux-data,@videojs/google-cast, or HTML element class names.Overview
Breaking rename for framework-neutral and HTML extension APIs:
MuxData/GoogleCastbecomeMuxDataExtension/GoogleCastExtension, with props types renamed to*ExtensionProps. Standalone default objects (muxDataDefaultProps,googleCastDefaultProps) are removed in favor ofstatic defaultPropson each class.@videojs/htmlcustom elements follow the same class names (MuxDataElement/GoogleCastElement→MuxDataExtension/GoogleCastExtension); tag names staymux-dataandgoogle-cast. Module entry points move from*-elementfiles toextension.ts, importing the base package class under a*Basealias where names collide.@videojs/reactkeeps publicMuxDataandGoogleCastcomponents unchanged; they now register the renamed classes and sync props againstExtension.defaultProps. Docs and the mux-data monitor lifecycle decision are updated to sayMuxDataExtension.Reviewed by Cursor Bugbot for commit d7b1402. Bugbot is set up for automated code reviews on this repo. Configure here.