refactor(skin): remove legacy skin implementation - #2550
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 29, 2026
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 19:09
1408dd9 to
1a45f3f
Compare
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 19:18
1a45f3f to
caef823
Compare
@videojs/core
@videojs/element
@videojs/html
@videojs/media
@videojs/react
@videojs/spf
@videojs/store
@videojs/utils
commit: |
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (18)
Extensions (2)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — 6 small size changes
Presets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (23)
📦 @videojs/spf — no changesEntries (10)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
2 times, most recently
from
August 29, 2026 19:42
a0dfcdc to
fe49ac8
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 19:47
fe49ac8 to
fc3b368
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 20:04
fc3b368 to
4e4908f
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 20:06
4e4908f to
03786d2
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 20:08
03786d2 to
e8e0118
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
2 times, most recently
from
August 29, 2026 20:14
d7cb69b to
ac29bc3
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
August 29, 2026 20:35
ac29bc3 to
862c5db
Compare
mihar-22
marked this pull request as ready for review
September 3, 2026 06:05
decepulis
approved these changes
Sep 3, 2026
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
September 3, 2026 18:52
326d65a to
b2dee22
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
September 3, 2026 18:53
b2dee22 to
c465e5e
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
September 3, 2026 18:53
c465e5e to
6f351e6
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
September 3, 2026 18:54
6f351e6 to
0536728
Compare
mihar-22
force-pushed
the
feat/remove-legacy-skins
branch
from
September 3, 2026 18:56
0536728 to
7bae74e
Compare
This was referenced Sep 3, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@videojs/skinsas the private VJSC source and generator owner while removing its obsolete publish buildVerification
pnpm build:packagespnpm build:cdnpnpm -F @videojs/html check:cdnpnpm build:sandboxpnpm check:workspaceCloses #2495
Parent: #2185
Stack
Note
Medium Risk
Large removal across presets, CSS bundling, and broad E2E parity coverage; regressions would show up as skin/CSS/Tailwind drift or broken CDN/HTML skin builds rather than auth or data risks.
Overview
Removes the legacy Default/Minimal skin stack and everything that still depended on it, so skins and tests treat VJSC as the only implementation path.
E2E and CI drop ejected-skin generation,
sync-ejected-skins, and HTML/React ejected fixtures; video control and visual suites no longer cover those pages. VJSC styling parity tests compare CSS vs Tailwind only (nosource=legacy), with layout contracts leaning on ARIA roles instead of legacymedia-*class hooks. Live-video caption tests now always expect menu-based captions.React package deletes the transitional
*skin.tailwind.tsxpresets and the@videojs/skinsdev dependency. HTML build CSS plugins no longer scan or resolve@videojs/skins/imports—only relative@imports under each package’ssrc/.Agent/docs cleanup: Tailwind migration skills and their references are removed from
.agents/skills/andAGENTS.md; design notes point preset styling atpackages/skins/vjsc/.Reviewed by Cursor Bugbot for commit 7bae74e. Bugbot is set up for automated code reviews on this repo. Configure here.